* [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function.
@ 2015-06-26 9:12 Amit Khatri
2015-08-13 8:54 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Amit Khatri @ 2015-06-26 9:12 UTC (permalink / raw)
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Rahul Jain, HEMANSHU SRIVASTAVA,
Nitin Jhanwar
DQpIaSBKb2hhbm5lcywNCg0KU3ViamVjdDogW1BBVENIIDMvNF0gaXc6IFN0YXRpYyBhbmFseXNl
ciByZXBvcnQgdGhhdCBhdHRyIG1heSBiZSBOVUxMIHNvDQogZWl0aGVyIHdlIGNhbiByZW1vdmUg
Y29uZGl0aW9uIGNoZWNrIHN0YXRlbWVudCBvciBhZGQgZ290byBhdCBlbmQgb2YgdGhpcw0KIGZ1
bmN0aW9uLg0KDQpTaWduZWQtb2ZmLWJ5OiBBbWl0IEtoYXRyaSA8YW1pdC5raGF0cmlAc2Ftc3Vu
Zy5jb20+DQpTaWduZWQtb2ZmLWJ5OiBSYWh1bCBKYWluIDxyYWh1bC5qYWluQHNhbXN1bmcuY29t
Pg0KLS0tDQogZXZlbnQuYyB8IDYgKysrKystDQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9u
cygrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvZXZlbnQuYyBiL2V2ZW50LmMNCmlu
ZGV4IGY3M2UwNzguLjA2ZDIzNmIgMTAwNjQ0DQotLS0gYS9ldmVudC5jDQorKysgYi9ldmVudC5j
DQpAQCAtNDksOCArNDksMTAgQEAgc3RhdGljIHZvaWQgcHJpbnRfZnJhbWUoc3RydWN0IHByaW50
X2V2ZW50X2FyZ3MgKmFyZ3MsIHN0cnVjdCBubGF0dHIgKmF0dHIpDQogCWNoYXIgbWFjYnVmWzYq
M107DQogCXVpbnQxNl90IHRtcDsNCiANCi0JaWYgKCFhdHRyKQ0KKwlpZiAoIWF0dHIpIHsNCiAJ
CXByaW50ZigiIFtubyBmcmFtZV0iKTsNCisJCWdvdG8gb3V0Ow0KKwl9DQogDQogCWZyYW1lID0g
bmxhX2RhdGEoYXR0cik7DQogCWxlbiA9IG5sYV9sZW4oYXR0cik7DQpAQCAtOTcsNiArOTksOCBA
QCBzdGF0aWMgdm9pZCBwcmludF9mcmFtZShzdHJ1Y3QgcHJpbnRfZXZlbnRfYXJncyAqYXJncywg
c3RydWN0IG5sYXR0ciAqYXR0cikNCiAJZm9yIChpID0gMDsgaSA8IGxlbjsgaSsrKQ0KIAkJcHJp
bnRmKCIgJS4wMngiLCBmcmFtZVtpXSk7DQogCXByaW50ZigiXSIpOw0KKyBvdXQ6DQorCTsgIC8q
ZW1wdHkgc3RhdGVtZW50IHRvIGF2b2lkIGNvbXBpbGVyIGVycm9yICovDQogfQ0KIA0KIHN0YXRp
YyB2b2lkIHBhcnNlX2NxbV9ldmVudChzdHJ1Y3QgbmxhdHRyICoqYXR0cnMpDQotLSANCjEuOS4x
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function.
2015-06-26 9:12 [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function Amit Khatri
@ 2015-08-13 8:54 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-08-13 8:54 UTC (permalink / raw)
To: amit.khatri
Cc: linux-wireless@vger.kernel.org, Rahul Jain, HEMANSHU SRIVASTAVA,
Nitin Jhanwar
On Fri, 2015-06-26 at 09:12 +0000, Amit Khatri wrote:
> Hi Johannes,
>
> Subject: [PATCH 3/4] iw: Static analyser report that attr may be NULL
> so
> either we can remove condition check statement or add goto at end of
> this
> function.
>
That's far far too much for the subject.
Please submit properly formatted patches with a single-line subject and
a more detailed description in the body.
> + out:
> + ; /*empty statement to avoid compiler error */
> }
Just doing "return;" instead of "goto out;" would seem more reasonable
than all these contortions?
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 9:12 [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function Amit Khatri
2015-08-13 8:54 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).