* [PATCH] cfg80211: propagate set_wiphy failure to userspace
@ 2015-08-03 8:55 Michal Kazior
2015-08-13 11:56 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Michal Kazior @ 2015-08-03 8:55 UTC (permalink / raw)
To: linux-wireless; +Cc: johannes, Michal Kazior
If driver failed to setup wiphy params (e.g. rts
threshold, fragmentation treshold) userspace
wasn't properly notified about this. This could
lead to user confusion who would think the command
succeeded even if that wasn't the case.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 76b41578a838..5849fa199f77 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2321,6 +2321,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
rdev->wiphy.frag_threshold = old_frag_threshold;
rdev->wiphy.rts_threshold = old_rts_threshold;
rdev->wiphy.coverage_class = old_coverage_class;
+ return result;
}
}
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cfg80211: propagate set_wiphy failure to userspace
2015-08-03 8:55 [PATCH] cfg80211: propagate set_wiphy failure to userspace Michal Kazior
@ 2015-08-13 11:56 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-08-13 11:56 UTC (permalink / raw)
To: Michal Kazior, linux-wireless
On Mon, 2015-08-03 at 10:55 +0200, Michal Kazior wrote:
> If driver failed to setup wiphy params (e.g. rts
> threshold, fragmentation treshold) userspace
> wasn't properly notified about this. This could
> lead to user confusion who would think the command
> succeeded even if that wasn't the case.
>
Applied.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-03 8:55 [PATCH] cfg80211: propagate set_wiphy failure to userspace Michal Kazior
2015-08-13 11:56 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).