* [PATCH 3/3] iw: Avoid possible memory leak for cb
@ 2015-08-13 10:29 Amit Khatri
2015-08-13 13:22 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Amit Khatri @ 2015-08-13 10:29 UTC (permalink / raw)
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Rahul Jain, HEMANSHU SRIVASTAVA,
Nitin Jhanwar
Y2IgZ290IG1lbW9yeSBmcm9tIG5sX2NiX2FsbG9jKCkgYnV0IG5vdCBkb2luZyBmcmVlDQpkdXJp
bmcgZXJyb3IgY2FzZSBhbmQgdXNlIHNhbWUgbGFibGUgdG8gZ28gb3V0IGZyb20gZnVuY3Rpb24u
DQoNClNpZ25lZC1vZmYtYnk6IEFtaXQgS2hhdHJpIDxhbWl0LmtoYXRyaUBzYW1zdW5nLmNvbT4N
ClNpZ25lZC1vZmYtYnk6IFJhaHVsIEphaW4gPHJhaHVsLmphaW5Ac2Ftc3VuZy5jb20+DQotLS0N
CiBpdy5jIHwgOCArKysrLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQg
ZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9pdy5jIGIvaXcuYw0KaW5kZXggZWM1NjczNi4u
YTJjMjc5NSAxMDA2NDQNCi0tLSBhL2l3LmMNCisrKyBiL2l3LmMNCkBAIC00NzYsMTMgKzQ3Niwx
MyBAQCBzdGF0aWMgaW50IF9faGFuZGxlX2NtZChzdHJ1Y3Qgbmw4MDIxMV9zdGF0ZSAqc3RhdGUs
IGVudW0gaWRfaW5wdXQgaWRieSwNCg0KICAgICAgICBlcnIgPSBjbWQtPmhhbmRsZXIoc3RhdGUs
IG1zZywgYXJnYywgYXJndiwgaWRieSk7DQogICAgICAgIGlmIChlcnIpDQotICAgICAgICAgICAg
ICAgZ290byBvdXQ7DQorICAgICAgICAgICAgICAgZ290byBvdXRfZnJlZV9tc2c7DQoNCiAgICAg
ICAgbmxfc29ja2V0X3NldF9jYihzdGF0ZS0+bmxfc29jaywgc19jYik7DQoNCiAgICAgICAgZXJy
ID0gbmxfc2VuZF9hdXRvX2NvbXBsZXRlKHN0YXRlLT5ubF9zb2NrLCBtc2cpOw0KICAgICAgICBp
ZiAoZXJyIDwgMCkNCi0gICAgICAgICAgICAgICBnb3RvIG91dDsNCisgICAgICAgICAgICAgICBn
b3RvIG91dF9mcmVlX21zZzsNCg0KICAgICAgICBlcnIgPSAxOw0KDQpAQCAtNDkzLDkgKzQ5Myw5
IEBAIHN0YXRpYyBpbnQgX19oYW5kbGVfY21kKHN0cnVjdCBubDgwMjExX3N0YXRlICpzdGF0ZSwg
ZW51bSBpZF9pbnB1dCBpZGJ5LA0KDQogICAgICAgIHdoaWxlIChlcnIgPiAwKQ0KICAgICAgICAg
ICAgICAgIG5sX3JlY3Ztc2dzKHN0YXRlLT5ubF9zb2NrLCBjYik7DQotIG91dDoNCi0gICAgICAg
bmxfY2JfcHV0KGNiKTsNCisNCiAgb3V0X2ZyZWVfbXNnOg0KKyAgICAgICBubF9jYl9wdXQoY2Ip
Ow0KICAgICAgICBubG1zZ19mcmVlKG1zZyk7DQogICAgICAgIHJldHVybiBlcnI7DQogIG5sYV9w
dXRfZmFpbHVyZToNCi0tDQoxLjkuMQ0K
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] iw: Avoid possible memory leak for cb
2015-08-13 10:29 [PATCH 3/3] iw: Avoid possible memory leak for cb Amit Khatri
@ 2015-08-13 13:22 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-08-13 13:22 UTC (permalink / raw)
To: amit.khatri
Cc: linux-wireless@vger.kernel.org, Rahul Jain, HEMANSHU SRIVASTAVA,
Nitin Jhanwar
This patch doesn't look correct - in the case that 'cb' fails to
allocate, the existing code is actually correct. In the case that s_cb
fails to allocate, it's clearly incorrect, but that means the two
conditions need to be disentangled, no?
Also, I've applied the other two patches despite them being severely
mangled - please try to improve your submission process so the patches
can apply - perhaps send them to yourself and see if 'git am' can
handle them to figure out what's wrong.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 10:29 [PATCH 3/3] iw: Avoid possible memory leak for cb Amit Khatri
2015-08-13 13:22 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).