From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:38080 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755222AbbHYJgw (ORCPT ); Tue, 25 Aug 2015 05:36:52 -0400 Message-ID: <1440495409.2192.16.camel@sipsolutions.net> (sfid-20150825_113659_245569_6956B4F3) Subject: Re: set channel from radiotap headers during injection From: Johannes Berg To: Allan Matthew Cc: linux-wireless@vger.kernel.org Date: Tue, 25 Aug 2015 11:36:49 +0200 In-Reply-To: (sfid-20150825_024629_360431_CBDD71CD) References: <1439983495.2089.7.camel@sipsolutions.net> <1440007745.2089.11.camel@sipsolutions.net> <1440013262.2089.13.camel@sipsolutions.net> <1440014031.2089.14.camel@sipsolutions.net> (sfid-20150825_024629_360431_CBDD71CD) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2015-08-24 at 17:46 -0700, Allan Matthew wrote: > > Johannes- What about txpower? Should this be configurable through > the radiotap headers? It's ... complicated. First of all, it's currently not supported I believe, in general, since there's no parsing code. Obviously, parsing code can be changed, and I think there might even be patches floating around for that. However, not all hardware supports per-frame TX power control. Some might, most will not. Until fairly recently, there was also no API with drivers to allow setting TX power per frame. This changed with the addition of TX power control to rate control, of course. So I think similar to rate control the situation is that it could be done, but there are many corner cases where it won't work reliably. I'd apply clean patches that add the functionality while documenting the issues. johannes