From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Arend van Spriel <arend@broadcom.com>
Subject: [PATCH 10/12] brcmfmac: remove ifidx parameter from brcmf_fws_txstatus_suppressed()
Date: Wed, 26 Aug 2015 22:15:02 +0200 [thread overview]
Message-ID: <1440620104-2715-11-git-send-email-arend@broadcom.com> (raw)
In-Reply-To: <1440620104-2715-1-git-send-email-arend@broadcom.com>
The brcmf_fws_txstatus_suppressed() function prototype specifies an
ifidx parameter which is not used within the function implementation.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index dc4844c..ed12486 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -1398,7 +1398,7 @@ done:
}
static int brcmf_fws_txstatus_suppressed(struct brcmf_fws_info *fws, int fifo,
- struct sk_buff *skb, u8 ifidx,
+ struct sk_buff *skb,
u32 genbit, u16 seq)
{
struct brcmf_fws_mac_descriptor *entry = brcmf_skbcb(skb)->mac;
@@ -1503,7 +1503,7 @@ brcmf_fws_txs_process(struct brcmf_fws_info *fws, u8 flags, u32 hslot,
return -EINVAL;
}
if (!remove_from_hanger)
- ret = brcmf_fws_txstatus_suppressed(fws, fifo, skb, ifp->ifidx,
+ ret = brcmf_fws_txstatus_suppressed(fws, fifo, skb,
genbit, seq);
if (remove_from_hanger || ret)
brcmf_txfinalize(ifp, skb, true);
--
1.9.1
next prev parent reply other threads:[~2015-08-26 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 20:14 [PATCH 00/12] brcmfmac: multiple interface rework and cleanup Arend van Spriel
2015-08-26 20:14 ` [PATCH 01/12] brcmfmac: consolidate ifp lookup in driver core Arend van Spriel
2015-09-29 7:29 ` [01/12] " Kalle Valo
2015-08-26 20:14 ` [PATCH 02/12] brcmfmac: make brcmf_proto_hdrpull() return struct brcmf_if instance Arend van Spriel
2015-08-26 20:14 ` [PATCH 03/12] brcmfmac: change parameters for brcmf_remove_interface() Arend van Spriel
2015-08-26 20:14 ` [PATCH 04/12] brcmfmac: only call brcmf_cfg80211_detach() when attach was successful Arend van Spriel
2015-08-26 20:14 ` [PATCH 05/12] brcmfmac: correct detection of p2pdev interface event Arend van Spriel
2015-08-26 20:14 ` [PATCH 06/12] brcmfmac: use brcmf_get_ifp() to map ifidx to struct brcmf_if instance Arend van Spriel
2015-08-26 20:14 ` [PATCH 07/12] brcmfmac: pass struct brcmf_if instance in brcmf_txfinalize() Arend van Spriel
2015-08-26 20:15 ` [PATCH 08/12] brcmfmac: add mapping for interface index to bsscfg index Arend van Spriel
2015-08-26 20:15 ` [PATCH 09/12] brcmfmac: add dedicated debug level for firmware console logging Arend van Spriel
2015-08-26 20:15 ` Arend van Spriel [this message]
2015-08-26 20:15 ` [PATCH 11/12] brcmfmac: change prototype for brcmf_fws_hdrpull() Arend van Spriel
2015-08-26 20:15 ` [PATCH 12/12] brcmfmac: introduce brcmf_net_detach() function Arend van Spriel
2015-08-26 21:54 ` [PATCH 00/12] brcmfmac: multiple interface rework and cleanup Rafał Miłecki
2015-08-27 7:13 ` Kalle Valo
2015-08-27 8:04 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440620104-2715-11-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).