From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>, Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: implement mesh support
Date: Thu, 10 Sep 2015 09:22:44 +0200 [thread overview]
Message-ID: <1441869764.2108.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20150909164945.GA4062@localhost> (sfid-20150909_184950_812635_9318273F)
On Wed, 2015-09-09 at 12:49 -0400, Bob Copeland wrote:
> On Wed, Sep 09, 2015 at 12:10:38PM +0300, Kalle Valo wrote:
> > > I did a quick smoke test and saw the splat below. It's this
> > > warning from
> > > cfg80211:
> > >
> > > /*
> > > * Don't advertise an unsupported type
> > > * in a combination.
> > > */
> > > if (WARN_ON((wiphy->interface_modes &
> > > types) != types))
> > > return -EINVAL;
>
> OK, this happens when mesh is configured out (we mask off the mesh
> interface_modes internally but not the types). Sent an updated
> version with appropriate ifdefs added.
Yeah this is an unfortunate quirk in the APIs ... I think adding the
ifdefs to the driver is the best thing to do.
johannes
next prev parent reply other threads:[~2015-09-10 7:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 10:57 [PATCH 0/3] mesh support for ath10k Bob Copeland
2015-08-27 10:57 ` [PATCH 1/3] ath10k: enable monitor when OTHER_BSS requested Bob Copeland
2015-08-27 10:57 ` [PATCH 2/3] ath10k: check for encryption before adding MIC_LEN Bob Copeland
2015-08-27 10:57 ` [PATCH 3/3] ath10k: implement mesh support Bob Copeland
2015-08-29 17:11 ` Jason Andryuk
2015-08-29 22:25 ` Bob Copeland
2015-08-30 17:43 ` Yeoh Chun-Yeow
2015-09-16 12:39 ` Bob Copeland
2015-09-17 17:48 ` Yeoh Chun-Yeow
2015-09-17 23:56 ` Peter Oh
2015-09-01 3:02 ` Jason Andryuk
2015-09-09 7:57 ` Kalle Valo
2015-09-09 9:10 ` Kalle Valo
2015-09-09 16:49 ` Bob Copeland
2015-09-10 5:46 ` Kalle Valo
2015-09-10 7:22 ` Johannes Berg [this message]
2015-09-15 7:21 ` Peter Oh
2015-09-16 12:32 ` Bob Copeland
2015-09-09 11:08 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441869764.2108.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).