From: Johannes Berg <johannes@sipsolutions.net>
To: Olav Haugan <ohaugan@codeaurora.org>, linux-wireless@vger.kernel.org
Cc: davem@davemloft.net, kvalo@codeaurora.org, ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH 1/2] mac80211: add support to set_coalesce
Date: Fri, 30 Oct 2015 10:59:41 +0100 [thread overview]
Message-ID: <1446199181.3261.21.camel@sipsolutions.net> (raw)
In-Reply-To: <1445712652-19327-1-git-send-email-ohaugan@codeaurora.org>
> +++ b/net/mac80211/driver-ops.h
> @@ -1355,4 +1355,16 @@ static inline void drv_wake_tx_queue(struct
> ieee80211_local *local,
> local->ops->wake_tx_queue(&local->hw, &txq->txq);
> }
>
> +static inline int drv_set_coalesce(struct ieee80211_local *local,
> + struct cfg80211_coalesce
> *coalesce)
> +{
> + u32 ret = 0;
>
This doesn't seem right - now you're accepting any call even if it's
not really done by the driver?
johannes
next prev parent reply other threads:[~2015-10-30 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 18:50 [PATCH 1/2] mac80211: add support to set_coalesce Olav Haugan
2015-10-24 18:50 ` [PATCH 2/2] ath9k: implement set_coalesce callback Olav Haugan
2015-10-30 10:00 ` Johannes Berg
2015-11-23 4:12 ` Olav Haugan
2015-11-23 8:52 ` Johannes Berg
2015-10-30 9:59 ` Johannes Berg [this message]
2015-11-23 4:02 ` [PATCH 1/2] mac80211: add support to set_coalesce Olav Haugan
-- strict thread matches above, loose matches on Subject: below --
2015-10-24 18:49 Olav Haugan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446199181.3261.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).