Re: [RFC 0/4] mac80211: jump labels for hw flags

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2015-11-09 at 23:42 +0100, Peter Zijlstra wrote:
> On Mon, Nov 09, 2015 at 11:02:33PM +0100, Johannes Berg wrote:
> > As far as the code is concerned, there are two really ugly things:
> >  1) I still use struct static_key - couldn't quite figure it out
> >     with static_key_false. I think I can replace it easily though.
> 
> Yeah, didn't see anything that would avoid using struct
> static_key_false. Was there anything specific that was difficult?

No, I think I just needed to wrap my head around the _ON and _OFF
semantics. I had originally thought I needed both _true and _false
static keys.

> >  2) There are a lot of boilerplate ifdefs/macros.
> 
> I'm sure we can reduce that a lot with some CPP trickery, lots of
> that looked like endless repetition of the same pattern.

Oh, it is, and I even generated it that way. I just haven't quite
figured out how to do that since you can't put an #if into a macro
expansion. Perhaps some tricks with the optimiser "if (0 && ..." or so.
I'll play with it.

For now though I think we need to figure out if we want this at all :)

johannes