From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Oh <poh@codeaurora.org>, Peter Oh <poh@qca.qualcomm.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: add VHT support for Mesh
Date: Thu, 12 Nov 2015 22:40:13 +0100 [thread overview]
Message-ID: <1447364413.2131.5.camel@sipsolutions.net> (raw)
In-Reply-To: <564505A6.9030001@codeaurora.org>
On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote:
>
> At this moment Mesh Point is not able to be brought up by userspace
> such
> as wap_supplicant at VHT data rates because there is no
> events/NL80211
> defined that userspace can check out if drivers can support Mesh
> Point
> (802.11s) at VHT data rates or not, hence only HT data rates can be
> used
> for
> Mesh Point by userspace now.
> This patch is introducing NL80211 event to cover the issue.
No... this patch doesn't introduce an nl80211 event. It introduces a
feature flag, but I'm arguing it's useless.
Look - what's the difference that userspace would do based on this
flag? Clearly, setting the flag in the driver has no effect on kernel
code whatsoever, so your "is not able to be brought up" makes no sense.
Perhaps it'll become clearer once you post the wpa_supplicant code, but
you should still coherently explain in the commit message why this is
necessary. So far, I don't see it, since no kernel code ever depends on
this flag.
johannes
next prev parent reply other threads:[~2015-11-12 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 17:59 [PATCH v2] cfg80211: add VHT support for Mesh Peter Oh
2015-11-12 20:03 ` Johannes Berg
2015-11-12 21:33 ` Peter Oh
2015-11-12 21:40 ` Johannes Berg [this message]
2015-11-12 22:28 ` Peter Oh
2015-11-12 22:32 ` Johannes Berg
2015-11-12 23:05 ` Peter Oh
2015-11-13 7:37 ` Johannes Berg
2015-11-13 23:50 ` Peter Oh
2015-11-15 14:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447364413.2131.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=poh@codeaurora.org \
--cc=poh@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).