Re: [PATCH v2] cfg80211: add VHT support for Mesh

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2015-11-12 at 15:05 -0800, Peter Oh wrote:
> On 11/12/2015 02:32 PM, Johannes Berg wrote:
> > On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote:
> > >   
> > > Exactly the same communication mechanism and purpose are used
> > > with
> > > NL80211_EXT_FEATURE_VHT_IBSS which is already a part of NL80211
> > > feature
> > > flag.
> > > The new feature flag, NL80211_EXT_FEATURE_VHT_MESH, follows the
> > > same
> > > purpose and usage.
> > No, it doesn't. Check how the _IBSS one is used in the code to
> > actually
> > *do* something.
> that's right. so take a look reset of explanation for this patch.
> 

Still not making sense.

I *suspect* that you think that the existing code is broken, and can't
use VHT mesh and requires driver changes for it, but that's not what
your ath10k change shows since it also does nothing at all.

Right now, I see no reason whatsoever to apply either one of those two
patches. There are no functional changes, so wpa_supplicant could
enable VHT mesh by checking VHT capabilities or so instead of a special
feature flag.

I also suspect that perhaps mesh *should* be checking like IBSS does,
although I also would actually *prefer* that we can assume VHT mesh
works if the driver advertises VHT support and mesh support separately,
i.e. a new feature flag really isn't necessary.

In any case, the arguments for this patch haven't convinced me. I'm not
going to apply this without much better ones.

johannes