From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Michal Marek <mmarek@suse.com>
Subject: Re: [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code
Date: Fri, 13 Nov 2015 10:52:32 +0100 [thread overview]
Message-ID: <1447408352.3271.11.camel@sipsolutions.net> (raw)
In-Reply-To: <CAGRGNgUr=ygLh-B1ZZ5ojPeRJVXCEbY3dniAtXZq_29DZzqjCw@mail.gmail.com> (sfid-20151113_104917_989701_911D22D2)
On Fri, 2015-11-13 at 20:48 +1100, Julian Calaby wrote:
>
> Am I missing something or are you not actually doing anything with
> MAC80211_DRIVER_NO_HWFLAGS?
>
Crap. I meant to pass it to the macro like this (I think):
#define __DEFINE_HWFLAG(_flg, _dyn, _on, _off) \
HWFLAGS_STATE_##_flg = -1 + (!(_dyn)) * (((_on) ^ (_off)) * (1 + (_on))),
#define DEFINE_HWFLAG(_flg) \
__DEFINE_HWFLAG(_flg, \
IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_DYN) || \
(CONFIG_MAC80211_DRIVER_NO_HWFLAGS > 0), \
CONFIG_MAC80211_HW_##_flg > 0, \
CONFIG_MAC80211_HW_##_flg < CONFIG_MAC80211_NUM_DRIVERS)
I'll take a closer look.
FWIW, I pushed this into the hwflags-elide branch in mac80211-next.git
(kernel.org) - will update there (also already fixed a compile issue)
johannes
next prev parent reply other threads:[~2015-11-13 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 22:00 [RFC v5 0/5] mac80211: elide code for static hw flags Johannes Berg
2015-11-12 22:00 ` [RFC v5 1/5] kconfig: introduce "count" Johannes Berg
2015-11-12 22:00 ` [RFC v5 2/5] kconfig: regenerate the shipped files Johannes Berg
2015-11-12 22:00 ` [RFC v5 3/5] mac80211: generate hw flags from include file Johannes Berg
2015-11-12 22:00 ` [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code Johannes Berg
2015-11-13 9:48 ` Julian Calaby
2015-11-13 9:52 ` Johannes Berg [this message]
2015-11-13 9:55 ` Johannes Berg
2015-11-20 15:24 ` Michal Marek
2015-11-20 15:29 ` Johannes Berg
2015-11-20 16:37 ` Michal Marek
2015-11-23 14:52 ` Michal Marek
2015-11-23 14:58 ` Johannes Berg
2015-11-23 15:06 ` Michal Marek
2015-11-23 15:15 ` Johannes Berg
2015-11-12 22:00 ` [RFC v5 5/5] iwlwifi: mvm: add Kconfig settings for hw flags Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447408352.3271.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).