From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-wireless@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
Peter Zijlstra <peterz@infradead.org>,
Michal Marek <mmarek@suse.com>
Subject: Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation
Date: Fri, 13 Nov 2015 17:35:39 +0100 [thread overview]
Message-ID: <1447432539.3271.23.camel@sipsolutions.net> (raw)
In-Reply-To: <20151113112922.3442aa1a@gandalf.local.home>
On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote:
> > - select MAC80211_HW_HAS_RATE_CONTROL_OFF
> > - select MAC80211_HW_RX_INCLUDES_FCS_OFF
>
> What happened to these two?
I removed the _OFF ones entirely, and instead with this patch am now
relying on modified logic:
_on = flags_counter > 0
_off = flags_counter < driver_counter
So the ones that are requested _OFF no longer need to be listed in
Kconfig - that was the entire point of doing the count (increment)
thing since we can then add new flags without touching all the drivers
to select them to _OFF.
> > +config MAC80211_NUM_DRIVERS
> > + int
> > + depends on MAC80211
>
> Why the depends? Does it make it 1 to start with?
>
No, it just removes it from the Kconfig entirely when you don't even
have MAC80211 instead of leaving it set there to 0. Probably not really
necessary, or could be better to put them all inside an "if mac80211"
block.
johannes
next prev parent reply other threads:[~2015-11-13 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 8:47 [RFC v4 0/8] mac80211: jump labels for HW flags Johannes Berg
2015-11-12 8:47 ` [RFC v4 1/8] mac80211: add ieee80211_hw_clear() Johannes Berg
2015-11-12 8:47 ` [RFC v4 2/8] mac80211: introduce ieee80211_local_check() Johannes Berg
2015-11-12 8:47 ` [RFC v4 3/8] mac80211: use static keys for hw flags Johannes Berg
2015-11-13 16:22 ` Steven Rostedt
2015-11-13 16:30 ` Johannes Berg
2015-11-12 8:47 ` [RFC v4 4/8] mac80211: test the static key code Johannes Berg
2015-11-12 8:47 ` [RFC v4 5/8] mac80211: generate hw flags from include file Johannes Berg
2015-11-13 16:25 ` Steven Rostedt
2015-11-13 16:31 ` Johannes Berg
2015-11-12 8:47 ` [RFC v4 6/8] kconfig: introduce "count" Johannes Berg
2015-11-13 16:26 ` Steven Rostedt
2015-11-13 16:32 ` Johannes Berg
2015-11-12 8:47 ` [RFC v4 7/8] kconfig: regenerate the shipped files Johannes Berg
2015-11-12 8:47 ` [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation Johannes Berg
2015-11-13 16:29 ` Steven Rostedt
2015-11-13 16:35 ` Johannes Berg [this message]
2015-11-13 16:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447432539.3271.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jbaron@akamai.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).