From: Johannes Berg <johannes@sipsolutions.net>
To: Olav Haugan <ohaugan@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, davem@davemloft.net,
kvalo@codeaurora.org, ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH 2/2] ath9k: implement set_coalesce callback
Date: Mon, 23 Nov 2015 09:52:07 +0100 [thread overview]
Message-ID: <1448268727.5792.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20151123041250.GA30745@codeaurora.org>
On Sun, 2015-11-22 at 20:12 -0800, Olav Haugan wrote:
> On 15-10-30 11:00:51, Johannes Berg wrote:
> > On Sat, 2015-10-24 at 11:50 -0700, Olav Haugan wrote:
> > > implement set_coalesce ieee80211_ops callback. Add default
> > > wiphy_coalesce_support rules for 9k. These rules are not being
> > > used
> > > by 9k since 9k can just toggle coalesce as on/off.
> > >
> > This seems extremely strange to me - like you're trying to abuse
> > set_coalesce, intended for coalescing certain classes of low-
> > importance
> > packets, for a completely different purpose (interrupt coalescing)?
> >
> Hmm, yes. We misunderstood how this API is used. Do you have any
> suggestion for how to accomplish what we are trying to do? We can't
> just add a new public user space API for this functionality.
ethtool usually has interrupt coalescing parameters.
johannes
next prev parent reply other threads:[~2015-11-23 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 18:50 [PATCH 1/2] mac80211: add support to set_coalesce Olav Haugan
2015-10-24 18:50 ` [PATCH 2/2] ath9k: implement set_coalesce callback Olav Haugan
2015-10-30 10:00 ` Johannes Berg
2015-11-23 4:12 ` Olav Haugan
2015-11-23 8:52 ` Johannes Berg [this message]
2015-10-30 9:59 ` [PATCH 1/2] mac80211: add support to set_coalesce Johannes Berg
2015-11-23 4:02 ` Olav Haugan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448268727.5792.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).