From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: (bug report) iwlwifi: inconsitent NULL checking
Date: Thu, 26 Nov 2015 13:51:37 +0100 [thread overview]
Message-ID: <1448542297.2167.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20151126123756.GF7289@mwanda>
On Thu, 2015-11-26 at 15:37 +0300, Dan Carpenter wrote:
>
> Ah. Thanks for looking at this. Eventually Smatch will be smart
> enoughto figure this implication out but not yet. No need to change
> the code because the static checker isn't capable enough...
>
Actually I just had an idea - we should put those two *checks* into an
inline anyway since they're actually really unlikely and we might not
want to take the function call every time...
So I thought that smatch would then be able to see through it, since
it's now an inline, but it doesn't seem like it can?
https://p.sipsolutions.net/a162ca550f675800.txt
johannes
next prev parent reply other threads:[~2015-11-26 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 12:03 (bug report) iwlwifi: inconsitent NULL checking Dan Carpenter
2015-11-26 12:16 ` Johannes Berg
2015-11-26 12:37 ` Dan Carpenter
2015-11-26 12:51 ` Johannes Berg [this message]
2015-11-26 19:44 ` Dan Carpenter
2015-11-26 20:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448542297.2167.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).