From: Johannes Berg <johannes@sipsolutions.net>
To: David Lin <dlin@marvell.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Chor Teck Law <ctlaw@marvell.com>, Pete Hsieh <peteh@marvell.com>
Subject: Re: [PATCH v7] Add new mac80211 driver mwlwifi.
Date: Fri, 27 Nov 2015 09:27:22 +0100 [thread overview]
Message-ID: <1448612842.2531.5.camel@sipsolutions.net> (raw)
In-Reply-To: <9d111cc7d61047b5890b7c5d53d71bbd@SC-EXCH02.marvell.com>
On Fri, 2015-11-27 at 02:00 +0000, David Lin wrote:
> > Ditto - you're allowed to modify mac80211. We actually have a patch
> > like this
> > already:
> > https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211-
> > next.git/commit/?id=99e7ca44bb910f0cbfda5d9008e8517df0ebc939
> >
>
> Once if this patch is ready, I will modify mwlwifi to use it. Thanks.
The patch is ready now and in the tree, but that wasn't my point. My
point is that you shouldn't try to hack around mac80211 like with the
action frame interception and the mesh-amsdu-reimplementation, but
actually go fix it.
If you have issues with mac80211 like this you can ask how to fix them,
or just fix them and suggest changes/patches, but just working around
it in the driver isn't the right approach.
johannes
next prev parent reply other threads:[~2015-11-27 8:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 3:51 [PATCH v7] Add new mac80211 driver mwlwifi David Lin
2015-11-12 19:47 ` Jes Sorensen
2015-11-26 8:34 ` David Lin
2015-11-20 11:22 ` Johannes Berg
2015-11-26 8:27 ` David Lin
2015-11-26 9:40 ` Johannes Berg
2015-11-27 2:00 ` David Lin
2015-11-27 8:27 ` Johannes Berg [this message]
2015-12-10 14:57 ` Kalle Valo
2015-12-15 7:54 ` David Lin
2015-12-10 14:06 ` Kalle Valo
[not found] ` <CANEJEGv7ENTJu4YHz1x2_ve2M6-3Nn8X-0aC2hA3o1mUs3tQ1g@mail.gmail.com>
2015-12-12 0:47 ` Grant Grundler
2015-12-14 11:47 ` Kalle Valo
2015-12-10 14:03 ` Kalle Valo
2015-12-10 14:39 ` Kalle Valo
2015-12-15 7:55 ` David Lin
2015-12-14 21:32 ` Kan Yan
2015-12-15 5:47 ` David Lin
2015-12-15 7:40 ` Emmanuel Grumbach
2015-12-15 7:53 ` David Lin
2016-03-16 23:24 ` Julian Calaby
2016-03-17 1:23 ` David Lin
2016-03-17 1:32 ` Julian Calaby
2016-03-17 2:10 ` David Lin
2016-04-03 12:05 ` Bjørn Mork
2016-04-15 12:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448612842.2531.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ctlaw@marvell.com \
--cc=dlin@marvell.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=peteh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).