From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211_hwsim: stop using pointers as cookies
Date: Fri, 27 Nov 2015 14:52:03 +0100 [thread overview]
Message-ID: <1448632323.1014.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20151108234923.GA30106@localhost> (sfid-20151109_005630_005048_7732FEA0)
On Sun, 2015-11-08 at 18:49 -0500, Bob Copeland wrote:
> On Fri, Nov 06, 2015 at 11:57:23AM +0100, Johannes Berg wrote:
> > Instead of using pointers, use sequentially assigned cookies.
> > This is easier to understand while debugging and also avoids
> > problems when the pointer is reused for the next allocation.
>
> I tested this out in wmediumd and it didn't go so well...
>
> > + info->rate_driver_data[0] = (void *)cookie;
>
> [...]
>
> > + skb_cookie = (u64)(uintptr_t)txi->driver_data[0];
>
> rate_driver_data vs driver_data?
Yep, that fixes it. I've applied the patch with that fix.
johannes
prev parent reply other threads:[~2015-11-27 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 10:57 [PATCH] mac80211_hwsim: stop using pointers as cookies Johannes Berg
2015-11-08 23:49 ` Bob Copeland
2015-11-27 13:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448632323.1014.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).