From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@codeaurora.org>,
"John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: wireless-testing regression: Could not configure driver mode
Date: Thu, 03 Dec 2015 08:50:39 +0100 [thread overview]
Message-ID: <1449129039.2181.0.camel@sipsolutions.net> (raw)
In-Reply-To: <87fuzkf2ef.fsf@kamboji.qca.qualcomm.com> (sfid-20151203_075426_533282_0EE08AA8)
On Thu, 2015-12-03 at 08:54 +0200, Kalle Valo wrote:
>
> --- a/net/mac80211/offchannel.c
> +++ b/net/mac80211/offchannel.c
> @@ -916,6 +916,13 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
> kfree_skb(skb);
> goto out_unlock;
> }
> + } else {
> + /* Assign a dummy non-zero cookie, it's not sent to
> + * userspace in this case but we rely on its value
> + * internally in the need_offchan case to distinguish
> + * mgmt-tx from remain-on-channel.
> + */
> + *cookie = 0xffffffff;
>
FWIW, this part isn't relevant for the problem and not actually an
error - this just went into my tree after that was merged into
wireless-testing :)
johannes
next prev parent reply other threads:[~2015-12-03 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 6:54 wireless-testing regression: Could not configure driver mode Kalle Valo
2015-12-03 7:50 ` Johannes Berg [this message]
2015-12-03 17:40 ` John W. Linville
2015-12-07 19:39 ` wireless-testing rebased, new HEAD commit f5feec4244464225c03ccc9ddad615cb43a044cc John W. Linville
2015-12-08 13:21 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449129039.2181.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).