wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

[Kalle Valo]

Hi,

For few weeks (I think) I have seen these kind of messages:

ath10k_pci 0000:02:00.0 wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

iwlwifi 0000:03:00.0 wlan0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800

I'm using ath.git master branch which is latest wireless-testing plus
latest ath patches. Any ideas what's causing these? mac80211 or
something else?

-- 
Kalle Valo

Re: wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

[Janusz Dziedzic]

On 3 December 2015 at 08:07, Kalle Valo <kvalo@codeaurora.org> wrote:
> Hi,
>
> For few weeks (I think) I have seen these kind of messages:
>
> ath10k_pci 0000:02:00.0 wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808
>
> iwlwifi 0000:03:00.0 wlan0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800
>
> I'm using ath.git master branch which is latest wireless-testing plus
> latest ath patches. Any ideas what's causing these? mac80211 or
> something else?
>
Missing:
net: fix feature changes on devices without ndo_set_features ?

BR
Janusz

> --
> Kalle Valo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

[Johannes Berg]

On Thu, 2015-12-03 at 09:03 +0100, Janusz Dziedzic wrote:
> 
> Missing:
> net: fix feature changes on devices without ndo_set_features ?
> 

According to the *code* that's there, but maybe Kalle hasn't recompiled
it to the latest tree quite right?

johannes

Re: wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

[Kalle Valo]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Thu, 2015-12-03 at 09:03 +0100, Janusz Dziedzic wrote:
>> 
>> Missing:
>> net: fix feature changes on devices without ndo_set_features ?
>> 
>
> According to the *code* that's there, but maybe Kalle hasn't recompiled
> it to the latest tree quite right?

Actually I was too hasty when reading the logs and missed that I haven't
seen these warnings since November 30th or so. I guess during after the
patch above trickled down to wireless-testing and fixed the issue.

So everything is good, sorry for the noise.

-- 
Kalle Valo

Re: wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

[Johannes Berg]

On Thu, 2015-12-03 at 09:07 +0200, Kalle Valo wrote:

> I'm using ath.git master branch which is latest wireless-testing plus
> latest ath patches. Any ideas what's causing these? mac80211 or
> something else?

This is usually caused by a driver (in this case mac80211) implementing
ndo_set_features, but I never accepted that patch as far as I remember,
it's pending in patchwork. I don't see that in your tree either, so
that's very puzzling.

Clearly it's trying to turn off NETIF_F_GSO, as it should since the
drivers both don't advertise NETIF_F_SG right now.

The code you're looking at is in __netdev_update_features(), but I
can't explain how it would get into this message if ndo_set_features is
NULL. Perhaps you should recompile the kernel from scratch.

johannes