From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Eyal Shapira <eyal@wizery.com>,
Eyal Shapira <eyalx.shapira@intel.com>
Subject: Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon
Date: Tue, 08 Dec 2015 16:58:27 +0100 [thread overview]
Message-ID: <1449590307.4154.13.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYL7h8ToceTfx8cV5VUtrr13Y1QZiPphWzznh2pitt457w@mail.gmail.com> (sfid-20151208_165600_461714_E8299054)
On Tue, 2015-12-08 at 21:25 +0530, Krishna Chaitanya wrote:
> On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg <johannes@sipsolutions.
> net> wrote:
> > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote:
> > >
> > > > If the rate control algorithm doesn't look at sta->sta.rx_nss
> > > > then
> > > > that's their bug.
> > >
> > > Yes, it looks like it. Only BW is handled, not the NSS change,
> > > and
> > > without this patch OP MODE IE in beacon updates neither NSS nor
> > > BW.
> > >
> > > For Action frame OP MODE IE, NSS will be updated.
> Typo BW will be updated.
Ok.
> > I don't see how that would happen - they end up in exactly the same
> > code path.
>
> As nss_only is false, BW will be update in case of action frame.
Well, this patch removes that since the whole concept of nss_only was
wrong.
So basically you're just saying that minstrel should be fixed to look
at rx_nss (and the relevant change bit, perhaps)...
johannes
next prev parent reply other threads:[~2015-12-08 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:04 [PATCH 0/9] various mac80211 / cfg80211 patches Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 1/9] mac80211: process and save VHT MU-MIMO group frame Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities Emmanuel Grumbach
2015-12-08 16:02 ` Krishna Chaitanya
2015-12-08 16:31 ` Grumbach, Emmanuel
[not found] ` <CABPxzYKp-97mNgtZZubiQ3Ew2VjOh-hFRPRwLY5WLvac9kU32g@mail.gmail.com>
2015-12-08 16:43 ` Grumbach, Emmanuel
[not found] ` <CABPxzYKZ8k1HvkygEuEy4dhc4xcc2ss9Bt8jJKcQ98DWZK9pvw@mail.gmail.com>
2015-12-08 19:06 ` Grumbach, Emmanuel
[not found] ` <CABPxzYJ445Xb1-znpG8w_8cUbZ1OVtBCCpgY9gOTPTpcs66DAQ@mail.gmail.com>
2015-12-08 19:22 ` Grumbach, Emmanuel
2015-12-09 7:00 ` Krishna Chaitanya
2015-12-08 14:04 ` [PATCH 3/9] mac80211: add flag for duplication check Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 4/9] mac80211: pass aggregation window size to lower level Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 5/9] mac80211: document status.freq restrictions Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon Emmanuel Grumbach
2015-12-08 15:38 ` Krishna Chaitanya
2015-12-08 15:42 ` Johannes Berg
2015-12-08 15:47 ` Krishna Chaitanya
2015-12-08 15:53 ` Johannes Berg
2015-12-08 15:55 ` Krishna Chaitanya
2015-12-08 15:58 ` Johannes Berg [this message]
2015-12-08 16:03 ` Krishna Chaitanya
2015-12-08 14:04 ` [PATCH 7/9] mac80211: suppress unchanged "limiting TX power" messages Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 8/9] mac80211: run scan completed work on reconfig failure Emmanuel Grumbach
2015-12-08 14:04 ` [PATCH 9/9] mac80211: reprogram in interface order Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449590307.4154.13.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=eyal@wizery.com \
--cc=eyalx.shapira@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox