* [patch] iwlwifi: mvm: remove an extra tab
@ 2015-12-09 10:26 Dan Carpenter
2015-12-09 10:41 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-12-09 10:26 UTC (permalink / raw)
To: Johannes Berg, Golan Ben-Ami
Cc: Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo,
linux-wireless, kernel-janitors
Smatch prints a static checker warning here:
drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:386 iwl_dump_prph()
warn: curly braces intended?
Curly braces are NOT intended, the extra tab was added by mistake in
commit 1a616dd2f171 ('iwlwifi: dump prph registers in a common place
for all transports').
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
index 9fcabc5..a6985da 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
@@ -383,7 +383,7 @@ static u32 iwl_dump_prph(struct iwl_trans *trans,
*val++ = cpu_to_le32(iwl_read_prph_no_grab(trans,
reg));
- *data = iwl_fw_error_next_data(*data);
+ *data = iwl_fw_error_next_data(*data);
}
iwl_trans_release_nic_access(trans, &flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] iwlwifi: mvm: remove an extra tab
2015-12-09 10:26 [patch] iwlwifi: mvm: remove an extra tab Dan Carpenter
@ 2015-12-09 10:41 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-12-09 10:41 UTC (permalink / raw)
To: Dan Carpenter, Golan Ben-Ami
Cc: Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo,
linux-wireless, kernel-janitors
On Wed, 2015-12-09 at 13:26 +0300, Dan Carpenter wrote:
> Smatch prints a static checker warning here:
>
> drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:386
> iwl_dump_prph()
> warn: curly braces intended?
>
> Curly braces are NOT intended, the extra tab was added by mistake in
> commit 1a616dd2f171 ('iwlwifi: dump prph registers in a common place
> for all transports').
>
Applied, thanks.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-09 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 10:26 [patch] iwlwifi: mvm: remove an extra tab Dan Carpenter
2015-12-09 10:41 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).