From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
linux-wireless@vger.kernel.org
Cc: nbd@openwrt.org
Subject: Re: [RFC/RFT 1/2] mac80211: Add NEED_ALIGNED4_SKBS hw flag
Date: Thu, 17 Dec 2015 11:04:27 +0100 [thread overview]
Message-ID: <1450346667.8247.23.camel@sipsolutions.net> (raw)
In-Reply-To: <1450344029-5296-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20151217_102050_152022_7DD1C619)
On Thu, 2015-12-17 at 10:20 +0100, Janusz Dziedzic wrote:
> HW/driver should set NEED_ALIGNED4_SKBS flag in case require
> aligned skbs to four-byte boundaries.
>
> Before we have to do memmove() in the driver before
> pass this to HW and memmove() back in tx completion.
> This patch allow to save CPU and skip such memmoves.
> For each skb we called memmove(ieee80211_hdrsize()) twice.
IMHO this is pretty awful from a code complexity POV. You also forgot
to update fast-xmit maximum header length.
Note that we (iwlwifi) also kinda need this, but essentially solve it
with the DMA engine. Can't ath9k do the same?
johannes
next prev parent reply other threads:[~2015-12-17 10:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 9:20 [RFC/RFT 1/2] mac80211: Add NEED_ALIGNED4_SKBS hw flag Janusz Dziedzic
2015-12-17 9:20 ` [RFC/RFT 2/2] ath9k: request aligned skb Janusz Dziedzic
2015-12-21 18:53 ` Souptick Joarder
2015-12-21 22:48 ` Julian Calaby
2015-12-17 9:39 ` [RFC/RFT 1/2] mac80211: Add NEED_ALIGNED4_SKBS hw flag Felix Fietkau
2015-12-17 10:04 ` Johannes Berg [this message]
2015-12-17 10:09 ` Felix Fietkau
2015-12-17 10:12 ` Felix Fietkau
2015-12-18 8:43 ` Janusz Dziedzic
2015-12-17 10:29 ` Johannes Berg
2015-12-17 10:35 ` Felix Fietkau
2015-12-17 10:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450346667.8247.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).