Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless@vger.kernel.org
Cc: nbd@openwrt.org
Subject: Re: [RFC/RFT v2] mac80211: Add NEED_ALIGNED4_SKBS hw flag
Date: Fri, 18 Dec 2015 13:07:38 +0100	[thread overview]
Message-ID: <1450440458.2849.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1450439850-1587-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20151218_125749_993352_562C800A)

On Fri, 2015-12-18 at 12:57 +0100, Janusz Dziedzic wrote:
> HW/driver should set NEED_ALIGNED4_SKBS flag in case require
> aligned skbs to four-byte boundaries.
> 
> Before we have to do memmove() in the driver before
> pass this to HW and memmove() back in tx completion.
> This patch allow to save CPU and skip such memmoves.
> For each skb we call memmove(ieee80211_hdrsize()) twice.
> 
> Currently this was tested with ath9k, both hw/sw crypt for
> tkip/ccmp.
> For sure more tests required (eg. fast path isn't used for
> ath9k STA, wep sw crypt).
> 
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
>  include/net/mac80211.h     |  4 ++++
>  net/mac80211/debugfs.c     |  1 +
>  net/mac80211/ieee80211_i.h |  1 +
>  net/mac80211/sta_info.h    |  4 ++--
>  net/mac80211/tkip.c        | 15 ++++++++++++---
>  net/mac80211/tx.c          | 38 +++++++++++++++++++++++++++++++++---
> --
>  net/mac80211/util.c        |  7 ++++++-
>  net/mac80211/wep.c         | 11 ++++++-----
>  net/mac80211/wep.h         |  1 +
>  net/mac80211/wpa.c         | 14 ++++++--------
>  10 files changed, 72 insertions(+), 24 deletions(-)
> 
Btw, how can you get away without changing the status path?

johannes

  reply	other threads:[~2015-12-18 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 11:57 [RFC/RFT v2] mac80211: Add NEED_ALIGNED4_SKBS hw flag Janusz Dziedzic
2015-12-18 12:07 ` Johannes Berg [this message]
2015-12-18 12:18   ` Janusz Dziedzic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450440458.2849.0.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=janusz.dziedzic@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox