From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:35889 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752326AbbLWEIi (ORCPT ); Tue, 22 Dec 2015 23:08:38 -0500 Message-ID: <1450843714.3537.8.camel@perches.com> (sfid-20151223_050909_461525_0D6E15FB) Subject: Re: [PATCH 44/45] iwlwifi: fix printf specifier From: Joe Perches To: Emmanuel Grumbach , linux-wireless@vger.kernel.org Date: Tue, 22 Dec 2015 20:08:34 -0800 In-Reply-To: <1450731046-2796-44-git-send-email-emmanuel.grumbach@intel.com> References: <0BA3FCBA62E2DC44AF3030971E174FB32E949792@hasmsx107.ger.corp.intel.com> <1450731046-2796-44-git-send-email-emmanuel.grumbach@intel.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2015-12-21 at 22:50 +0200, Emmanuel Grumbach wrote: > Smatch warned about a bad specifier being used. Fix that. I see nothing here other than a signed/unsigned issue that shouldn't need fixing.  The conversion from hex to decimal may not be useful. > Signed-off-by: Emmanuel Grumbach > --- >  drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c > index b395854..c15f5be 100644 > --- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c > @@ -454,11 +454,11 @@ static void iwl_eeprom_enhanced_txpower(struct device *dev, >    TXP_CHECK_AND_PRINT(COMMON_TYPE), >    txp->flags); >   IWL_DEBUG_EEPROM(dev, > -  "\t\t chain_A: 0x%02x chain_B: 0X%02x chain_C: 0X%02x\n", > +  "\t\t chain_A: %d chain_B: %d chain_C: %d\n", >    txp->chain_a_max, txp->chain_b_max, >    txp->chain_c_max); >   IWL_DEBUG_EEPROM(dev, > -  "\t\t MIMO2: 0x%02x MIMO3: 0x%02x High 20_on_40: 0x%02x Low 20_on_40: 0x%02x\n", > +  "\t\t MIMO2: %d MIMO3: %d High 20_on_40: 0x%02x Low 20_on_40: 0x%02x\n", >    txp->mimo2_max, txp->mimo3_max, >    ((txp->delta_20_in_40 & 0xf0) >> 4), >    (txp->delta_20_in_40 & 0x0f));