From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
linux-wireless@vger.kernel.org
Cc: j@w1.fi
Subject: Re: [PATCH v2 1/2] mac80211: check requested flags in ieee80211_tx_prepare_skb()
Date: Wed, 06 Jan 2016 11:44:08 +0100 [thread overview]
Message-ID: <1452077048.2541.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1451990134-15183-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20160105_113556_363725_B1436A7B)
On Tue, 2016-01-05 at 11:35 +0100, Janusz Dziedzic wrote:
> In case driver already set info->flags (eg.
> IEEE80211_TX_CTL_NO_CCK_RATE
> in ath9k driver), before this patch we skip this requested flags.
I don't see how we "skip" them?
> + unsigned int flags = info->flags;
>
> if (ieee80211_tx_prepare(sdata, &tx, NULL, skb) == TX_DROP)
> return false;
>
> info->band = band;
> info->control.vif = vif;
> info->hw_queue = vif->hw_queue[skb_get_queue_mapping(skb)];
> + info->flags |= flags;
tx_prepare() doesn't [seem to] do anything to the flags but twiddle a
few, so ?
johannes
next prev parent reply other threads:[~2016-01-06 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 10:35 [PATCH v2 1/2] mac80211: check requested flags in ieee80211_tx_prepare_skb() Janusz Dziedzic
2016-01-05 10:35 ` [PATCH v2 2/2] ath9k: use min rate when MCC and nullfunc Janusz Dziedzic
2016-01-21 13:11 ` Kalle Valo
2016-01-06 10:44 ` Johannes Berg [this message]
2016-01-07 6:17 ` [PATCH v2 1/2] mac80211: check requested flags in ieee80211_tx_prepare_skb() Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452077048.2541.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).