From: Johannes Berg <johannes@sipsolutions.net>
To: Lior David <liord@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Jouni Malinen <jouni@qca.qualcomm.com>,
Dedy Lansky <dlansky@codeaurora.org>,
Maya Erez <merez@codeaurora.org>,
Hamad Kadmany <qca_hkadmany@qca.qualcomm.com>
Subject: Re: [PATCH] cfg80211: basic support for PBSS network type
Date: Tue, 26 Jan 2016 13:54:29 +0100 [thread overview]
Message-ID: <1453812869.2759.38.camel@sipsolutions.net> (raw)
In-Reply-To: <56A767E4.7090906@codeaurora.org>
> Yes, DMG devices can function as a full AP in addition to PCP.
Ok. I'll try to remember :)
> Certified 11ad devices must support PBSS, but in theory you can have
> 11ad drivers that do not support it. 11ac devices cannot support
> it and currently will just ignore this flag, so I think I will add a
> feature flag (something like NL80211_EXT_FEATURE_PBSS) and return an
> error if the driver does not support this feature.
I'd rather return an error when the device isn't 11ad.
If it's basically a requirement then I don't think we really need a
feature flag, but can just have the driver reject the flag in the
meantime. I do want to avoid having a situation where userspace
specified PBSS and it gets ignored entirely though.
> I have a patch for the wil6210 driver that uses this feature. Do you
> prefer that I add the wil6210 driver changes to this patch?
Great. No, I don't want bigger wil6210 changes in this patch, so I'd
prefer you add a few lines to this patch that make wil6210 reject the
configuration with PBSS, and then obviously in the real wil6210 patch
remove that again.
johannes
next prev parent reply other threads:[~2016-01-26 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 9:04 [PATCH] cfg80211: basic support for PBSS network type Lior David
2016-01-26 11:22 ` Johannes Berg
2016-01-26 12:34 ` Lior David
2016-01-26 12:54 ` Johannes Berg [this message]
2016-01-28 8:58 ` [PATCH v2] " Lior David
2016-02-02 15:09 ` Johannes Berg
2016-02-02 15:10 ` Johannes Berg
2016-02-03 9:24 ` Lior David
2016-02-03 15:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453812869.2759.38.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dlansky@codeaurora.org \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=liord@codeaurora.org \
--cc=merez@codeaurora.org \
--cc=qca_hkadmany@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).