From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Beniamino Galvani <bgalvani@redhat.com>
Subject: Re: [PATCH] wext: fix message delay/ordering
Date: Wed, 27 Jan 2016 13:17:20 +0100 [thread overview]
Message-ID: <1453897040.2351.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1453896850-22775-1-git-send-email-johannes@sipsolutions.net> (sfid-20160127_131419_031860_43892E09)
On Wed, 2016-01-27 at 13:14 +0100, Johannes Berg wrote:
>
> +static int wext_netdev_notifier_call(struct notifier_block *nb,
> + unsigned long state, void *ptr)
> +{
> + /*
> + * When a netdev is unregistered, flush all pending messages
> + * to avoid them going out after the RTM_DELLINK, which can
> + * happen due to the schedule_work().
> + */
> + if (state == NETDEV_UNREGISTER)
> + wireless_nlevent_flush();
>
It could be argued that the state check isn't really necessary and
should be removed to avoid ordering issues with up/down vs. wext, but
this fixes the really strange issue where you get an RTM_NEWLINK after
RTM_DELLINK (with the same ifidx), and I don't see how any software
would care much about the ordering otherwise.
johannes
next prev parent reply other threads:[~2016-01-27 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 12:14 [PATCH] wext: fix message delay/ordering Johannes Berg
2016-01-27 12:17 ` Johannes Berg [this message]
2016-01-27 12:18 ` Johannes Berg
2016-01-27 12:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453897040.2351.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bgalvani@redhat.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).