From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven@open-mesh.com>, linux-wireless@vger.kernel.org
Cc: thomas@net.t-labs.tu-berlin.de, antonio@open-mesh.com, nbd@nbd.name
Subject: Re: [PATCH] mac80211: minstrel: Scale expected_throughput by 10
Date: Mon, 01 Feb 2016 13:30:37 +0100 [thread overview]
Message-ID: <1454329837.3211.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1454329450-31527-1-git-send-email-sven@open-mesh.com> (sfid-20160201_132429_424750_8B5B02B5)
On Mon, 2016-02-01 at 13:24 +0100, Sven Eckelmann wrote:
> The change from cur_tp to the function
> minstrel_get_tp_avg/minstrel_ht_get_tp_avg changed the unit used for
> the
> current throughtput. For example in minstrel_ht the correct
> conversion between them would be:
>
> mrs->cur_tp / 10 == minstrel_ht_get_tp_avg(..).
>
> This factor 10 must also be included in the calculation of
> minstrel_get_expected_throughput and
> minstrel_ht_get_expected_throughput to
> get similar results as before the change.
>
10 is a pretty expensive factor, perhaps that should use 16 instead?
johannes
next prev parent reply other threads:[~2016-02-01 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 12:24 [PATCH] mac80211: minstrel: Scale expected_throughput by 10 Sven Eckelmann
2016-02-01 12:30 ` Johannes Berg [this message]
2016-02-01 12:56 ` Sven Eckelmann
2016-02-01 12:57 ` Johannes Berg
2016-02-01 12:58 ` Antonio Quartulli
2016-02-01 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454329837.3211.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=antonio@open-mesh.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sven@open-mesh.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).