From: Joe Perches <joe@perches.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Rakhi Sharma <rakhish1994@gmail.com>,
Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.
Date: Mon, 01 Feb 2016 06:28:21 -0800 [thread overview]
Message-ID: <1454336901.7329.63.camel@perches.com> (raw)
In-Reply-To: <wrfjio287gwy.fsf@redhat.com>
On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote:
> Joe Perches <joe@perches.com> writes:
[]
> > so this could be transformed into something like:
> >
> > int rtw_get_bit_value_from_ieee_value23a(u8 val)
> > {
> > int i;
> > static const u8 dot11_rate_table[] = {
> > 2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108
> > };
>
> and per my previous email, the above is worse than than the original.
> The cleaner way to list it would be:
>
> static const char dot11_rate_table[] =
> { 2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108 };
Either style is OK, but the style I used is slightly
more common in the kernel overall, about 2:1.
The type should ideally be u8 and not char.
next prev parent reply other threads:[~2016-02-01 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 13:24 [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue Rakhi Sharma
2016-01-31 14:36 ` Jes Sorensen
2016-01-31 17:25 ` Joe Perches
2016-02-01 12:29 ` Jes Sorensen
2016-02-01 14:28 ` Joe Perches [this message]
2016-02-01 15:02 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454336901.7329.63.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rakhish1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).