* [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning.
@ 2016-02-01 12:51 Rakhi Sharma
2016-02-01 14:51 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Rakhi Sharma @ 2016-02-01 12:51 UTC (permalink / raw)
To: Jes.Sorensen, gregkh; +Cc: linux-wireless, Rakhi Sharma
Fixed a braces style warning.
Warning: braces {} are not necessary for single statement blocks.
Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
index 0c933e4..365f780 100644
--- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
@@ -176,11 +176,9 @@ u8 *rtw_get_ie23a(u8 *pbuf, int index, int *len, int limit)
int tmp, i;
u8 *p;
- if (limit < 1) {
+ if (limit < 1)
return NULL;
- }
-
p = pbuf;
i = 0;
*len = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning.
2016-02-01 12:51 [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning Rakhi Sharma
@ 2016-02-01 14:51 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-02-01 14:51 UTC (permalink / raw)
To: Rakhi Sharma, Jes.Sorensen, gregkh; +Cc: linux-wireless
On Mon, 2016-02-01 at 18:21 +0530, Rakhi Sharma wrote:
> Fixed a braces style warning.
> Warning: braces {} are not necessary for single statement blocks.
[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
[]
> @@ -176,11 +176,9 @@ u8 *rtw_get_ie23a(u8 *pbuf, int index, int *len, int limit)
> int tmp, i;
> u8 *p;
>
> - if (limit < 1) {
> + if (limit < 1)
>
> return NULL;
> - }
> -
> p = pbuf;
> i = 0;
> *len = 0;
This ends up as:
if (limit < 1)
return NULL;
p = pbuf;
And isn't particularly more readable.
It would be better as:
if (limit < 1)
return NULL;
p = pbuf;
etc...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-01 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 12:51 [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning Rakhi Sharma
2016-02-01 14:51 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).