linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaehyun Lim <chaehyun.lim@gmail.com>
To: gregkh@linuxfoundation.org
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
	chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
	leo.kim@atmel.com, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org, Chaehyun Lim <chaehyun.lim@gmail.com>
Subject: [PATCH 4/8] staging: wilc1000: fix return error code of wilc_deinit
Date: Fri,  5 Feb 2016 10:35:14 +0900	[thread overview]
Message-ID: <1454636118-9943-4-git-send-email-chaehyun.lim@gmail.com> (raw)
In-Reply-To: <1454636118-9943-1-git-send-email-chaehyun.lim@gmail.com>

It should be returned error code as -EFAULT instead of 0 when hif_drv is
NULL.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 36eeeb4..6c91071 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3890,7 +3890,7 @@ int wilc_deinit(struct wilc_vif *vif)
 
 	if (!hif_drv)	{
 		PRINT_ER("hif_drv = NULL\n");
-		return 0;
+		return -EFAULT;
 	}
 
 	down(&hif_sema_deinit);
-- 
2.7.0


  parent reply	other threads:[~2016-02-05  1:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05  1:35 [PATCH 1/8] staging: wilc1000: fix return type of wilc_hif_set_cfg Chaehyun Lim
2016-02-05  1:35 ` [PATCH 2/8] staging: wilc1000: rename pstrCfgParamVal in wilc_hif_set_cfg Chaehyun Lim
2016-02-05  1:35 ` [PATCH 3/8] staging: wilc1000: fix return type of wilc_deinit Chaehyun Lim
2016-02-05  1:35 ` Chaehyun Lim [this message]
2016-02-05  1:35 ` [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt Chaehyun Lim
2016-02-07 21:51   ` Greg KH
2016-02-05  1:35 ` [PATCH 6/8] staging: wilc1000: use int type for counter variable Chaehyun Lim
2016-02-05  1:35 ` [PATCH 7/8] staging: wilc1000: remove initialization code of " Chaehyun Lim
2016-02-05  1:35 ` [PATCH 8/8] staging: wilc1000: rename counter in wilc_send_config_pkt Chaehyun Lim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454636118-9943-4-git-send-email-chaehyun.lim@gmail.com \
    --to=chaehyun.lim@gmail.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).