linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaehyun Lim <chaehyun.lim@gmail.com>
To: gregkh@linuxfoundation.org
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
	chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
	leo.kim@atmel.com, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org, Chaehyun Lim <chaehyun.lim@gmail.com>
Subject: [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt
Date: Fri,  5 Feb 2016 10:35:15 +0900	[thread overview]
Message-ID: <1454636118-9943-5-git-send-email-chaehyun.lim@gmail.com> (raw)
In-Reply-To: <1454636118-9943-1-git-send-email-chaehyun.lim@gmail.com>

wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return
value of wilc_wlan_cfg_get or wilc_wlan_cfg_set.
It is better to use int type to represent linux standard error code.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 49ae9b1..323a0cd 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -449,10 +449,11 @@ s32 wilc_dealloc_assoc_resp_info(tstrConnectRespInfo *pstrConnectRespInfo)
  *  @date		1 Mar 2012
  *  @version	1.0
  */
-s32 wilc_send_config_pkt(struct wilc *wilc, u8 mode, struct wid *wids,
+int wilc_send_config_pkt(struct wilc *wilc, u8 mode, struct wid *wids,
 			 u32 count, u32 drv)
 {
-	s32 counter = 0, ret = 0;
+	s32 counter = 0;
+	int ret = 0;
 
 	if (mode == GET_CFG) {
 		for (counter = 0; counter < count; counter++) {
-- 
2.7.0


  parent reply	other threads:[~2016-02-05  1:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05  1:35 [PATCH 1/8] staging: wilc1000: fix return type of wilc_hif_set_cfg Chaehyun Lim
2016-02-05  1:35 ` [PATCH 2/8] staging: wilc1000: rename pstrCfgParamVal in wilc_hif_set_cfg Chaehyun Lim
2016-02-05  1:35 ` [PATCH 3/8] staging: wilc1000: fix return type of wilc_deinit Chaehyun Lim
2016-02-05  1:35 ` [PATCH 4/8] staging: wilc1000: fix return error code " Chaehyun Lim
2016-02-05  1:35 ` Chaehyun Lim [this message]
2016-02-07 21:51   ` [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt Greg KH
2016-02-05  1:35 ` [PATCH 6/8] staging: wilc1000: use int type for counter variable Chaehyun Lim
2016-02-05  1:35 ` [PATCH 7/8] staging: wilc1000: remove initialization code of " Chaehyun Lim
2016-02-05  1:35 ` [PATCH 8/8] staging: wilc1000: rename counter in wilc_send_config_pkt Chaehyun Lim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454636118-9943-5-git-send-email-chaehyun.lim@gmail.com \
    --to=chaehyun.lim@gmail.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).