* [PATCH] nl80211: Zero out the connection keys memory when freeing them.
@ 2016-02-11 0:00 Ola Olsson
2016-02-11 0:12 ` Julian Calaby
2016-02-23 9:41 ` Johannes Berg
0 siblings, 2 replies; 3+ messages in thread
From: Ola Olsson @ 2016-02-11 0:00 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Ola Olsson, Ola Olsson
The connection keys are zeroed out in all other cases except this
one. Let's fix the last one as well.
Signed-off-by: Ola Olsson <ola.olsson@sonymobile.com>
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 72de698..c1ef6ce 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -7547,7 +7547,7 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
if ((ibss.chandef.width != NL80211_CHAN_WIDTH_20_NOHT) &&
no_ht) {
- kfree(connkeys);
+ kzfree(connkeys);
return -EINVAL;
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: Zero out the connection keys memory when freeing them.
2016-02-11 0:00 [PATCH] nl80211: Zero out the connection keys memory when freeing them Ola Olsson
@ 2016-02-11 0:12 ` Julian Calaby
2016-02-23 9:41 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2016-02-11 0:12 UTC (permalink / raw)
To: Ola Olsson; +Cc: Johannes Berg, linux-wireless, Ola Olsson
Hi Ola,
On Thu, Feb 11, 2016 at 11:00 AM, Ola Olsson <ola1olsson@gmail.com> wrote:
> The connection keys are zeroed out in all other cases except this
> one. Let's fix the last one as well.
>
> Signed-off-by: Ola Olsson <ola.olsson@sonymobile.com>
Makes sense to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 72de698..c1ef6ce 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -7547,7 +7547,7 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
>
> if ((ibss.chandef.width != NL80211_CHAN_WIDTH_20_NOHT) &&
> no_ht) {
> - kfree(connkeys);
> + kzfree(connkeys);
> return -EINVAL;
> }
> }
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: Zero out the connection keys memory when freeing them.
2016-02-11 0:00 [PATCH] nl80211: Zero out the connection keys memory when freeing them Ola Olsson
2016-02-11 0:12 ` Julian Calaby
@ 2016-02-23 9:41 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2016-02-23 9:41 UTC (permalink / raw)
To: Ola Olsson; +Cc: linux-wireless, Ola Olsson
On Thu, 2016-02-11 at 01:00 +0100, Ola Olsson wrote:
> The connection keys are zeroed out in all other cases except this
> one. Let's fix the last one as well.
>
Applied.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 0:00 [PATCH] nl80211: Zero out the connection keys memory when freeing them Ola Olsson
2016-02-11 0:12 ` Julian Calaby
2016-02-23 9:41 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).