From: "Avery Pennarun" <apenwarr@gmail.com>
To: linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@vger.kernel.org, johannes@sipsolutions.net,
nbd@nbd.name
Cc: Avery Pennarun <apenwarr@gmail.com>
Subject: [PATCH] mac80211: debugfs var for the default aggregation timeout.
Date: Tue, 16 Feb 2016 16:28:11 -0500 [thread overview]
Message-ID: <1455658091-28262-2-git-send-email-apenwarr@gmail.com> (raw)
In-Reply-To: <1455658091-28262-1-git-send-email-apenwarr@gmail.com>
Since around the beginning of time, ath9k aggregates have timed out after
5000 TU (around 5000ms) of inactivity, but nobody seems to be quite sure
why, and this magic number seems to have migrated around from one place to
another. An openbsd mailing list recently had a patch to disable the
timeout completely, which they say matches some commercial routers:
https://www.mail-archive.com/tech@openbsd.org/msg29456.html
Even in Linux, several non-ath9k drivers default to no timeout already. I
think changing it directly to zero would be safe, but to allow a more
structured investigation, let's make it configurable for now.
Signed-off-by: Avery Pennarun <apenwarr@gmail.com>
---
net/mac80211/debugfs_netdev.c | 4 ++++
net/mac80211/rc80211_minstrel_ht.c | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
index 37ea30e..5ae160b 100644
--- a/net/mac80211/debugfs_netdev.c
+++ b/net/mac80211/debugfs_netdev.c
@@ -715,6 +715,8 @@ static void add_mesh_config(struct ieee80211_sub_if_data *sdata)
}
#endif
+u32 default_agg_timeout = 5000;
+
static void add_files(struct ieee80211_sub_if_data *sdata)
{
if (!sdata->vif.debugfs_dir)
@@ -725,6 +727,8 @@ static void add_files(struct ieee80211_sub_if_data *sdata)
DEBUGFS_ADD(txpower);
DEBUGFS_ADD(user_power_level);
DEBUGFS_ADD(ap_power_level);
+ debugfs_create_u32("default_agg_timeout", 0600, sdata->vif.debugfs_dir,
+ &default_agg_timeout);
if (sdata->vif.type != NL80211_IFTYPE_MONITOR)
add_common_files(sdata);
diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index 3928dbd..028d9d4 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -671,6 +671,8 @@ minstrel_downgrade_rate(struct minstrel_ht_sta *mi, u16 *idx, bool primary)
}
}
+extern u32 default_agg_timeout;
+
static void
minstrel_aggr_check(struct ieee80211_sta *pubsta, struct sk_buff *skb)
{
@@ -691,7 +693,7 @@ minstrel_aggr_check(struct ieee80211_sta *pubsta, struct sk_buff *skb)
if (likely(sta->ampdu_mlme.tid_tx[tid]))
return;
- ieee80211_start_tx_ba_session(pubsta, tid, 5000);
+ ieee80211_start_tx_ba_session(pubsta, tid, default_agg_timeout);
}
static void
--
2.7.0.rc3.207.g0ac5344
next prev parent reply other threads:[~2016-02-16 21:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 5:03 ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Avery Pennarun
2016-02-16 21:28 ` Avery Pennarun
2016-02-16 21:28 ` Avery Pennarun [this message]
2016-02-16 21:44 ` [PATCH] mac80211: debugfs var for the default aggregation timeout Johannes Berg
2016-02-17 2:05 ` Sujith Manoharan
2016-02-23 10:14 ` Johannes Berg
2016-02-23 18:43 ` Avery Pennarun
2016-02-23 20:05 ` Johannes Berg
2016-04-05 23:46 ` Avery Pennarun
2016-04-06 7:40 ` Johannes Berg
2016-04-08 1:32 ` Avery Pennarun
2016-04-08 6:56 ` Johannes Berg
2016-04-08 7:01 ` Johannes Berg
2016-04-08 7:15 ` Johannes Berg
2016-04-08 8:31 ` Avery Pennarun
2016-04-09 1:27 ` Avery Pennarun
2016-04-09 4:56 ` Johannes Berg
2016-04-10 0:31 ` Adrian Chadd
2016-04-10 1:59 ` bruce m beach
2016-04-19 1:29 ` Avery Pennarun
2016-02-16 22:05 ` ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Johannes Berg
2016-02-17 4:32 ` Avery Pennarun
2016-02-17 6:23 ` Krishna Chaitanya
2016-02-17 7:05 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455658091-28262-2-git-send-email-apenwarr@gmail.com \
--to=apenwarr@gmail.com \
--cc=ath9k-devel@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).