linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Avery Pennarun <apenwarr@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	ath9k-devel@vger.kernel.org, nbd@nbd.name
Subject: Re: ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins
Date: Tue, 16 Feb 2016 23:05:29 +0100	[thread overview]
Message-ID: <1455660329.2723.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1455658091-28262-1-git-send-email-apenwarr@gmail.com> (sfid-20160216_222824_263622_E1EF34E2)

On Tue, 2016-02-16 at 16:28 -0500, Avery Pennarun wrote:
> 
> Changing default_agg_timeout to zero (as it is on most non-ath9k
> drivers) makes the problem pretty much go away.  However, I think
> it's because I'm just dodging the code path that triggers a race
> condition.

That does seem likely. Perhaps you could reproduce it while running
mac80211 tracing? There should be a fair amount of information about
aggregation and queue stops in there, though as you note queue stops
aren't really happening, only aggregation related things. Perhaps the
tracepoints for that aren't quite sufficient.

> Notes:
> 
> - I'm using exactly the same ath9k driver (currently 20150525, but
> we've   tried newer ones with no difference) on two totally different
> platforms: a dual-core mindspeed c2k host CPU (ARMv7) with separate
> ath9k, and a single-core QCA9531 (MIPS) with on-chip ath9k.
> 
> - I've been unable to trigger the problem on the QCA9531, but I have
> on MIPS.

That's ... not what I would have expected, especially since the MIPS is
single core. That makes the races stranger than expected.

> The aggregation code is... a little hairy.  Does anyone have any
> guesses where I might look for the race condition?  Or better still,
> a patch I can try?

I'm not aware of any race conditions in the code right now :)

johannes

  parent reply	other threads:[~2016-02-16 22:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  5:03 ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Avery Pennarun
2016-02-16 21:28 ` Avery Pennarun
2016-02-16 21:28   ` [PATCH] mac80211: debugfs var for the default aggregation timeout Avery Pennarun
2016-02-16 21:44     ` Johannes Berg
2016-02-17  2:05     ` Sujith Manoharan
2016-02-23 10:14     ` Johannes Berg
2016-02-23 18:43       ` Avery Pennarun
2016-02-23 20:05         ` Johannes Berg
2016-04-05 23:46           ` Avery Pennarun
2016-04-06  7:40             ` Johannes Berg
2016-04-08  1:32               ` Avery Pennarun
2016-04-08  6:56                 ` Johannes Berg
2016-04-08  7:01                   ` Johannes Berg
2016-04-08  7:15                     ` Johannes Berg
2016-04-08  8:31                       ` Avery Pennarun
2016-04-09  1:27                         ` Avery Pennarun
2016-04-09  4:56                           ` Johannes Berg
2016-04-10  0:31                             ` Adrian Chadd
2016-04-10  1:59                               ` bruce m beach
2016-04-19  1:29                                 ` Avery Pennarun
2016-02-16 22:05   ` Johannes Berg [this message]
2016-02-17  4:32     ` ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Avery Pennarun
2016-02-17  6:23       ` Krishna Chaitanya
2016-02-17  7:05         ` Avery Pennarun
  -- strict thread matches above, loose matches on Subject: below --
2015-11-04  5:20 Avery Pennarun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455660329.2723.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=apenwarr@gmail.com \
    --cc=ath9k-devel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).