From: Leo Kim <leo.kim@atmel.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
<tony.cho@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
<austin.shin@atmel.com>, <Chris.Park@atmel.com>,
<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: [PATCH V3 04/24] staging: wilc1000: linux_mon.c: add to check routine
Date: Mon, 22 Feb 2016 13:11:49 +0900 [thread overview]
Message-ID: <1456114329-7036-5-git-send-email-leo.kim@atmel.com> (raw)
In-Reply-To: <1456114329-7036-1-git-send-email-leo.kim@atmel.com>
This patch adds the return value which needs the check and
prints the error message when it fails.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
---
drivers/staging/wilc1000/linux_mon.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index 2b575d1..dd9e4b2 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -266,7 +266,9 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
/* if source address and bssid fields are equal>>Mac header */
/*send it to mgmt frames handler */
if (!(memcmp(srcAdd, bssid, 6))) {
- mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
+ ret = mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
+ if (ret)
+ netdev_err(dev, "fail to mgmt tx\n");
dev_kfree_skb(skb);
} else {
ret = wilc_mac_xmit(skb, mon_priv->real_ndev);
--
1.9.1
next prev parent reply other threads:[~2016-02-22 4:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 4:11 [PATCH V3 00/24] staging: wilc1000: Resend V3 Leo Kim
2016-02-22 4:11 ` [PATCH V3 01/24] staging: wilc1000: wilc_wlan.c: removes PRINT_ER Leo Kim
2016-02-22 4:11 ` [PATCH V3 02/24] staging: wilc1000: linux_mon.c: removes debug logs Leo Kim
2016-02-22 4:11 ` [PATCH V3 03/24] staging: wilc1000: linux_mon.c: replaces PRINT_ER with netdev_err Leo Kim
2016-02-22 4:11 ` Leo Kim [this message]
2016-02-22 4:11 ` [PATCH V3 05/24] staging: wilc1000: removes potential null dereference Leo Kim
2016-02-22 4:11 ` [PATCH V3 06/24] staging: wilc1000: host_interface.c: removes unnecessary log message Leo Kim
2016-02-22 4:11 ` [PATCH V3 07/24] staging: wilc1000: linux_mon.c: " Leo Kim
2016-02-22 4:11 ` [PATCH V3 08/24] staging: wilc1000: linux_mon.c: removes comments Leo Kim
2016-02-22 4:11 ` [PATCH V3 09/24] staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages Leo Kim
2016-02-22 4:11 ` [PATCH V3 10/24] staging: wilc1000: removes unused HOSTAPD_DBG tag Leo Kim
2016-02-22 4:11 ` [PATCH V3 11/24] staging: wilc1000: host_interface.c: removes unnecessary log messages Leo Kim
2016-02-22 4:11 ` [PATCH V3 12/24] staging: wilc1000: wilc_wfi_cfgoperations.c: " Leo Kim
2016-02-22 4:11 ` [PATCH V3 13/24] " Leo Kim
2016-02-22 4:11 ` [PATCH V3 14/24] staging: wilc1000: removes unused CFG80211_DBG tag Leo Kim
2016-02-22 4:12 ` [PATCH V3 15/24] staging: wilc1000: coreconfigurator.c: removes unnecessary log messages Leo Kim
2016-02-22 4:12 ` [PATCH V3 16/24] staging: wilc1000: host_interface.c: " Leo Kim
2016-02-22 4:12 ` [PATCH V3 17/24] staging: wilc1000: host_interface.c: replace PRINT_ER with netdev_err Leo Kim
2016-02-22 4:12 ` [PATCH V3 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages Leo Kim
2016-02-22 4:12 ` [PATCH V3 19/24] staging: wilc1000: wilc_wfi_cfgoperations.c: " Leo Kim
2016-02-22 4:12 ` [PATCH V3 20/24] staging: wilc1000: wilc_wlan.c: " Leo Kim
2016-02-22 4:12 ` [PATCH V3 21/24] staging: wilc1000: removes unused region feature Leo Kim
2016-02-22 4:12 ` [PATCH V3 22/24] staging: wilc1000: removes usused PRINT_XX(region...) Leo Kim
2016-02-22 4:12 ` [PATCH V3 23/24] staging: wilc1000: moves to define values Leo Kim
2016-02-22 4:12 ` [PATCH V3 24/24] staging: wilc1000: moves LINUX_RX_SIZE, LINUX_TX_SIZE Leo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456114329-7036-5-git-send-email-leo.kim@atmel.com \
--to=leo.kim@atmel.com \
--cc=Chris.Park@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).