From: Leo Kim <leo.kim@atmel.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
<tony.cho@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
<austin.shin@atmel.com>, <Chris.Park@atmel.com>,
<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log
Date: Mon, 22 Feb 2016 13:41:13 +0900 [thread overview]
Message-ID: <1456116079-7161-4-git-send-email-leo.kim@atmel.com> (raw)
In-Reply-To: <1456116079-7161-1-git-send-email-leo.kim@atmel.com>
This patch removes unnecessary wilc_debug print log.
The print log was written when if condition fail.
The condition is chip-id check function.
Also, replaces this condition with normal function.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
---
drivers/staging/wilc1000/wilc_wlan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
index f0ac47f..34018a1 100644
--- a/drivers/staging/wilc1000/wilc_wlan.c
+++ b/drivers/staging/wilc1000/wilc_wlan.c
@@ -502,9 +502,7 @@ void chip_wakeup(struct wilc *wilc)
do {
usleep_range(2 * 1000, 2 * 1000);
- if ((wilc_get_chipid(wilc, true) == 0))
- wilc_debug(N_ERR, "Couldn't read chip id. Wake up failed\n");
-
+ wilc_get_chipid(wilc, true);
} while ((wilc_get_chipid(wilc, true) == 0) && ((++trials % 3) == 0));
} while (wilc_get_chipid(wilc, true) == 0);
--
1.9.1
next prev parent reply other threads:[~2016-02-22 4:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 4:41 [PATCH RESEND 01/10] staging: wilc1000: removes wilc_dbg() Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 02/10] staging: wilc1000: replaces wilc_debug with netdev_err Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 03/10] staging: wilc1000: removes unnecessary wilc_debug print log Leo Kim
2016-02-22 4:41 ` Leo Kim [this message]
2016-02-22 10:45 ` [PATCH RESEND 04/10] " Dan Carpenter
2016-02-22 11:42 ` Kim, Leo
2016-02-22 14:44 ` Dan Carpenter
2016-02-23 5:29 ` Kim, Leo
2016-02-22 4:41 ` [PATCH RESEND 05/10] staging: wilc1000: removes unnecessary variable of wilc_mac_cfg_t structure Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 06/10] staging: wilc1000: wilc_wlan_cfg_init: changes unused argument Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 07/10] staging: wilc1000: move WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 08/10] staging: wilc1000: move MODALIS and GPIO_NUM define to wilc_wlan.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 09/10] staging: wilc1000: remove useless define in linux_wlan_common.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 10/10] staging: wilc1000: removes " Leo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456116079-7161-4-git-send-email-leo.kim@atmel.com \
--to=leo.kim@atmel.com \
--cc=Chris.Park@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).