linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s
@ 2016-02-08 13:25 Felix Fietkau
  2016-02-23 10:02 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2016-02-08 13:25 UTC (permalink / raw)
  To: linux-wireless; +Cc: johannes

reuse_skb is set to true if the code decides to use the last segment.
Fixes a memory leak

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
 net/wireless/util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index 6e4eb35..9880c89 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -676,7 +676,7 @@ void ieee80211_amsdu_to_8023s(struct sk_buff *skb, struct sk_buff_head *list,
 	u8 *payload;
 	int offset = 0, remaining, err;
 	struct ethhdr eth;
-	bool reuse_skb = true;
+	bool reuse_skb = false;
 	bool last = false;
 
 	if (has_80211_header) {
-- 
2.2.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s
  2016-02-08 13:25 [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s Felix Fietkau
@ 2016-02-23 10:02 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2016-02-23 10:02 UTC (permalink / raw)
  To: Felix Fietkau, linux-wireless

On Mon, 2016-02-08 at 14:25 +0100, Felix Fietkau wrote:
> reuse_skb is set to true if the code decides to use the last segment.
> Fixes a memory leak
> 
Applied.

johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-23 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 13:25 [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s Felix Fietkau
2016-02-23 10:02 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).