From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mac80211: parse VHT info in injected frames
Date: Tue, 23 Feb 2016 11:10:50 +0100 [thread overview]
Message-ID: <1456222250.2041.8.camel@sipsolutions.net> (raw)
In-Reply-To: <1455878585-5525-3-git-send-email-lorenzo.bianconi83@gmail.com> (sfid-20160219_114311_450464_CF0925C0)
On Fri, 2016-02-19 at 11:43 +0100, Lorenzo Bianconi wrote:
> Add VHT radiotap parsing support to ieee80211_parse_tx_radiotap().
> That capability has been tested using a d-link dir-860l rev b1
> running
> OpenWrt trunk and mt76 driver
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
> ---
> Documentation/networking/mac80211-injection.txt | 10 ++++++++
> net/mac80211/tx.c | 31
> +++++++++++++++++++++++++
> 2 files changed, 41 insertions(+)
>
> diff --git a/Documentation/networking/mac80211-injection.txt
> b/Documentation/networking/mac80211-injection.txt
> index ec8f934..ef57cc0 100644
> --- a/Documentation/networking/mac80211-injection.txt
> +++ b/Documentation/networking/mac80211-injection.txt
> @@ -45,6 +45,16 @@ radiotap headers and used to control injection:
> number of retries when either IEEE80211_RADIOTAP_RATE or
> IEEE80211_RADIOTAP_MCS was used
>
> + * IEEE80211_RADIOTAP_VHT
> +
> + VHT rate for the transmission (only for devices without own rate
> control).
> + Also some flags are parsed
> +
> + IEEE80211_TX_RC_SHORT_GI: use short guard interval
> + IEEE80211_TX_RC_40_MHZ_WIDTH: send in HT40 mode
> + IEEE80211_TX_RC_80_MHZ_WIDTH: send in HT80 mode
> + IEEE80211_TX_RC_160_MHZ_WIDTH: send in HT160 mode
>
This makes no sense, those are mac80211 internal flags, should document
the radiotap flags here, not what they map to internally.
johannes
next prev parent reply other threads:[~2016-02-23 10:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 10:43 [PATCH v2 0/2] add VHT radiotap parsing support to mac80211 Lorenzo Bianconi
2016-02-19 10:43 ` [PATCH v2 1/2] cfg80211: add radiotap VHT info to rtap_namespace_sizes Lorenzo Bianconi
2016-02-23 10:18 ` Johannes Berg
2016-02-19 10:43 ` [PATCH v2 2/2] mac80211: parse VHT info in injected frames Lorenzo Bianconi
2016-02-23 10:10 ` Johannes Berg [this message]
2016-02-23 10:29 ` Lorenzo Bianconi
2016-02-23 10:42 ` Johannes Berg
2016-02-23 10:49 ` Lorenzo Bianconi
2016-02-23 10:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456222250.2041.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).