* [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
@ 2016-02-11 6:47 Ujjal Roy
2016-02-11 9:35 ` Kalle Valo
2016-02-15 23:45 ` Julian Calaby
0 siblings, 2 replies; 7+ messages in thread
From: Ujjal Roy @ 2016-02-11 6:47 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Cathy Luo, Nishant Sarmukadam, Kalle Valo, WiFi Mailing List
This patch fixes the incorrect indentation of the case label.
Signed-off-by: Ujjal Roy <royujjal@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index e7adef7..cb0cf03 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
}
break;
- case MWIFIEX_BSS_ROLE_STA:
+ case MWIFIEX_BSS_ROLE_STA:
if (priv->media_connected) {
mwifiex_dbg(adapter, ERROR,
"cannot change wiphy params when connected");
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
2016-02-11 6:47 [PATCH 1/3] " Ujjal Roy
@ 2016-02-11 9:35 ` Kalle Valo
2016-02-11 15:02 ` Ujjal Roy
2016-02-24 19:26 ` Ujjal Roy
2016-02-15 23:45 ` Julian Calaby
1 sibling, 2 replies; 7+ messages in thread
From: Kalle Valo @ 2016-02-11 9:35 UTC (permalink / raw)
To: Ujjal Roy
Cc: Amitkumar Karwar, Cathy Luo, Nishant Sarmukadam,
WiFi Mailing List
Ujjal Roy <royujjal@gmail.com> writes:
> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
A changelog is always recommended to have. Also for some reason your
name in patchwork is all caps:
Submitter UJJAL ROY
https://patchwork.kernel.org/patch/8276851/
Please try to fix that, but I don't know if that's even possible.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
2016-02-11 9:35 ` Kalle Valo
@ 2016-02-11 15:02 ` Ujjal Roy
2016-02-24 19:26 ` Ujjal Roy
1 sibling, 0 replies; 7+ messages in thread
From: Ujjal Roy @ 2016-02-11 15:02 UTC (permalink / raw)
To: Kalle Valo
Cc: Amitkumar Karwar, Cathy Luo, Nishant Sarmukadam,
WiFi Mailing List
On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Ujjal Roy <royujjal@gmail.com> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo
I checked that and unable to change the name. If you have any
suggestion please share with me.
Thanks,
UjjaL Roy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
2016-02-11 6:47 [PATCH 1/3] " Ujjal Roy
2016-02-11 9:35 ` Kalle Valo
@ 2016-02-15 23:45 ` Julian Calaby
1 sibling, 0 replies; 7+ messages in thread
From: Julian Calaby @ 2016-02-15 23:45 UTC (permalink / raw)
To: Ujjal Roy
Cc: Amitkumar Karwar, Cathy Luo, Nishant Sarmukadam, Kalle Valo,
WiFi Mailing List
Hi All,
On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy <royujjal@gmail.com> wrote:
> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index e7adef7..cb0cf03 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
> }
> break;
>
> - case MWIFIEX_BSS_ROLE_STA:
> + case MWIFIEX_BSS_ROLE_STA:
> if (priv->media_connected) {
> mwifiex_dbg(adapter, ERROR,
> "cannot change wiphy params when connected");
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
@ 2016-02-24 19:19 UJJAL ROY
2016-03-07 12:32 ` [1/3] " Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: UJJAL ROY @ 2016-02-24 19:19 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Cathy Luo, Nishant Sarmukadam, Kalle Valo, WiFi Mailing List
This patch fixes the incorrect indentation of the case label.
Signed-off-by: UJJAL ROY <royujjal@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index e7adef7..cb0cf03 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
}
break;
- case MWIFIEX_BSS_ROLE_STA:
+ case MWIFIEX_BSS_ROLE_STA:
if (priv->media_connected) {
mwifiex_dbg(adapter, ERROR,
"cannot change wiphy params when connected");
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue
2016-02-11 9:35 ` Kalle Valo
2016-02-11 15:02 ` Ujjal Roy
@ 2016-02-24 19:26 ` Ujjal Roy
1 sibling, 0 replies; 7+ messages in thread
From: Ujjal Roy @ 2016-02-24 19:26 UTC (permalink / raw)
To: Kalle Valo
Cc: Amitkumar Karwar, Cathy Luo, Nishant Sarmukadam,
WiFi Mailing List
I have sent all the patches again with my name in CAPITAL letter.
Please have a look.
Thanks,
UjjaL Roy
On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Ujjal Roy <royujjal@gmail.com> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [1/3] mwifiex: Fixed incorrect indentation issue
2016-02-24 19:19 [PATCH 1/3] mwifiex: Fixed incorrect indentation issue UJJAL ROY
@ 2016-03-07 12:32 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2016-03-07 12:32 UTC (permalink / raw)
To: Ujjal Roy
Cc: Amitkumar Karwar, Cathy Luo, Nishant Sarmukadam,
WiFi Mailing List
> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
Thanks, 3 patches applied to wireless-drivers-next.git:
32962d5b43b7 mwifiex: Fixed incorrect indentation issue
3a968d766a63 mwifiex: Removed extra spaces before commas
354a1947a025 mwifiex: Added missing spaces around brackets
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-07 12:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 19:19 [PATCH 1/3] mwifiex: Fixed incorrect indentation issue UJJAL ROY
2016-03-07 12:32 ` [1/3] " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2016-02-11 6:47 [PATCH 1/3] " Ujjal Roy
2016-02-11 9:35 ` Kalle Valo
2016-02-11 15:02 ` Ujjal Roy
2016-02-24 19:26 ` Ujjal Roy
2016-02-15 23:45 ` Julian Calaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).