From: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>
To: "janusz.dziedzic@tieto.com" <janusz.dziedzic@tieto.com>,
"Valo, Kalle" <kvalo@qca.qualcomm.com>,
"greearb@candelatech.com" <greearb@candelatech.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/4] ath10k: remove supported chain mask
Date: Thu, 25 Feb 2016 17:39:08 +0000 [thread overview]
Message-ID: <1456421947524.85405@qti.qualcomm.com> (raw)
In-Reply-To: <1456233812853.59898@qti.qualcomm.com>
>>>> Removing supported chainmask fields as it can be always derived
>>>> from num_rf_chains.
>>>>
>>>> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>>>
>> Hello,
>>
>> This one break monitor mode for qca988x and 10.x firmware:
>> After Revert "ath10k: remove supported chain mask" - works correctly.
>>
>Janusz,
>
> Thanks for reporting. Will send out patch asap.
>
Janusz,
It seems the change ("ath10k: remove supported chain mask") just exposed an
hidden problem. The same target assert can be reproduced by below sequence
even after reverting the commit.
ifconfig wlan0 down
iw wlan0 set type monitor
iw phy0 set antenna 7
ifconfig wlan0 up
The actual cause of target assert is below commit.
commit 5572a95b4b5768187652a346356e39e7542ca6e0
Author: Ben Greear <greearb@candelatech.com>
Date: Mon Nov 24 16:22:10 2014 +0200
ath10k: apply chainmask settings to vdev on creation
Configuring NSS vdev param on interface addition is causing the target assert in 10.1 firmware.
Just creating monitor interface is causing assert with qca_main firmware.
-Rajkumar
next prev parent reply other threads:[~2016-02-25 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:21 [PATCH 1/4] ath10k: remove supported chain mask Rajkumar Manoharan
2015-10-27 12:21 ` [PATCH 2/4] ath10k: fill HT/VHT MCS rateset only for configured chainmask Rajkumar Manoharan
2015-10-27 12:21 ` [PATCH 3/4] ath10k: move static HT/VHT capability setup functions Rajkumar Manoharan
2015-10-27 12:21 ` [PATCH 4/4] ath10k: reload HT/VHT capabilities on antenna change Rajkumar Manoharan
2015-10-29 11:01 ` [PATCH 1/4] ath10k: remove supported chain mask Kalle Valo
2016-02-23 12:52 ` Janusz Dziedzic
2016-02-23 13:23 ` Manoharan, Rajkumar
2016-02-25 17:39 ` Manoharan, Rajkumar [this message]
2016-02-25 18:40 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456421947524.85405@qti.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=janusz.dziedzic@tieto.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).