* [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
@ 2016-02-27 18:28 Edward Lipinsky
2016-02-27 18:48 ` Joe Perches
2016-03-12 19:45 ` [PATCHv2] " Edward Lipinsky
0 siblings, 2 replies; 4+ messages in thread
From: Edward Lipinsky @ 2016-02-27 18:28 UTC (permalink / raw)
To: Larry.Finger, Jes.Sorensen, gregkh; +Cc: linux-wireless, devel, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index ce4b589..03202df 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
}
spin_unlock_bh(&pacl_node_q->lock);
- DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+ DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
+ pacl_list->num);
rtw_sta_flush23a(padapter);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
2016-02-27 18:28 [PATCH] staging: rtl8723au: Fix line longer than 80 columns Edward Lipinsky
@ 2016-02-27 18:48 ` Joe Perches
2016-03-01 16:54 ` Edward Lipinsky
2016-03-12 19:45 ` [PATCHv2] " Edward Lipinsky
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2016-02-27 18:48 UTC (permalink / raw)
To: Edward Lipinsky, Larry.Finger, Jes.Sorensen, gregkh
Cc: linux-wireless, devel, linux-kernel
On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> }
> spin_unlock_bh(&pacl_node_q->lock);
>
> - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
> + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
> + pacl_list->num);
It's generally nicer to break the line at the end
of the format sting like:
DBG_8723A("%s, free acl_node_queue, num =%d\n",
__func__, pacl_list->num);
though it'd be even better to convert all of these
DBG_8723A uses to pr_debug
$ git ls-files drivers/staging/rtl8723au/ | \
xargs sed -r -i \
-e 's/\bDBG_8723A\b/pr_debug/g' \
-e 's/\bMSG|8723A\b/pr_debug/g'
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
2016-02-27 18:48 ` Joe Perches
@ 2016-03-01 16:54 ` Edward Lipinsky
0 siblings, 0 replies; 4+ messages in thread
From: Edward Lipinsky @ 2016-03-01 16:54 UTC (permalink / raw)
To: Joe Perches
Cc: Larry.Finger, Jes.Sorensen, gregkh, linux-wireless, devel,
linux-kernel
On Sat, Feb 27, 2016 at 10:48:56AM -0800, Joe Perches wrote:
> On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: line over 80 characters
> []
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> []
> > @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> > }
> > spin_unlock_bh(&pacl_node_q->lock);
> >
> > - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
> > + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
> > + pacl_list->num);
>
> It's generally nicer to break the line at the end
> of the format sting like:
>
> DBG_8723A("%s, free acl_node_queue, num =%d\n",
> __func__, pacl_list->num);
>
> though it'd be even better to convert all of these
> DBG_8723A uses to pr_debug
>
> $ git ls-files drivers/staging/rtl8723au/ | \
> xargs sed -r -i \
> -e 's/\bDBG_8723A\b/pr_debug/g' \
> -e 's/\bMSG|8723A\b/pr_debug/g'
>
Thanks for the feedback. I will submit an updated patch.
Ed
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv2] staging: rtl8723au: Fix line longer than 80 columns.
2016-02-27 18:28 [PATCH] staging: rtl8723au: Fix line longer than 80 columns Edward Lipinsky
2016-02-27 18:48 ` Joe Perches
@ 2016-03-12 19:45 ` Edward Lipinsky
1 sibling, 0 replies; 4+ messages in thread
From: Edward Lipinsky @ 2016-03-12 19:45 UTC (permalink / raw)
To: Larry.Finger, Jes.Sorensen, gregkh; +Cc: linux-wireless, devel, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
---
Change in v2:
- Break the line after the format string, as suggested by Joe
Perches <joe@perches.com>.
drivers/staging/rtl8723au/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index ce4b589..67c9d90 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
}
spin_unlock_bh(&pacl_node_q->lock);
- DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+ DBG_8723A("%s, free acl_node_queue, num =%d\n",
+ __func__, pacl_list->num);
rtw_sta_flush23a(padapter);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-12 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-27 18:28 [PATCH] staging: rtl8723au: Fix line longer than 80 columns Edward Lipinsky
2016-02-27 18:48 ` Joe Perches
2016-03-01 16:54 ` Edward Lipinsky
2016-03-12 19:45 ` [PATCHv2] " Edward Lipinsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).