Re: [PATCH] mac80211: fix AP buffered multicast frames with queue control and txq

[Johannes Berg <johannes@sipsolutions.net>]

On Sun, 2016-02-28 at 09:35 -0800, Dave Taht wrote:
> On Sun, Feb 28, 2016 at 6:19 AM, Felix Fietkau <nbd@openwrt.org>
> wrote:
> > Buffered multicast frames must be passed to the driver directly via
> > drv_tx instead of going through the txq, otherwise they cannot
> > easily be
> > scheduled to be sent after DTIM.
> > 
> > Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> > ---
> >  net/mac80211/tx.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> > index 3a7475f..b294820 100644
> > --- a/net/mac80211/tx.c
> > +++ b/net/mac80211/tx.c
> > @@ -1247,7 +1247,8 @@ static void ieee80211_drv_tx(struct
> > ieee80211_local *local,
> >         struct txq_info *txqi;
> >         u8 ac;
> > 
> > -       if (info->control.flags & IEEE80211_TX_CTRL_PS_RESPONSE)
> > +       if ((info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) ||
> > +           (info->control.flags & IEEE80211_TX_CTRL_PS_RESPONSE))
> >                 goto tx_normal;
> > 
> >         if (!ieee80211_is_data(hdr->frame_control))
> > --
> > 2.2.2
> 
> I would like 

Feel free to propose patches for anything you like :)

johannes
>