From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>, linux-wireless@vger.kernel.org
Cc: egrumbach@gmail.com
Subject: Re: [PATCH v2 1/2] mac80211: add A-MSDU tx support
Date: Thu, 03 Mar 2016 16:37:27 +0100 [thread overview]
Message-ID: <1457019447.2044.24.camel@sipsolutions.net> (raw)
In-Reply-To: <56D85428.6090705@openwrt.org>
On Thu, 2016-03-03 at 16:11 +0100, Felix Fietkau wrote:
>
> For my own uses, I'd be perfectly fine with limiting A-MSDU size to
> HT limits even when using VHT - in fact I did that in an early RFC
> patch. I mainly relaxed the limit for VHT based on Emmanuel's
> feedback. I also have doubts about the value of A-MSDU size beyond
> 4095 bytes.
>
> Just let me know which way you'd like it, and I'll send v3
> accordingly.
>
I don't really know, I can live with both ways. I'm just a bit worried
that we make enabling this feature so complex that nobody will get it
right.
Perhaps we could also just remove this, make the default
for max_rc_amsdu_len be 4095 (or so) and leave the rest to the rate
control? We could entirely remove this check here, and let minstrel
only use higher values if VHT is supported (and consequently will be
used)?
johannes
next prev parent reply other threads:[~2016-03-03 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 9:28 [PATCH v2 1/2] mac80211: add A-MSDU tx support Felix Fietkau
2016-02-24 9:29 ` [PATCH v2 2/2] mac80211: minstrel_ht: set A-MSDU tx limits based on selected max_prob_rate Felix Fietkau
2016-03-03 14:55 ` Johannes Berg
2016-03-03 15:03 ` Felix Fietkau
2016-03-03 15:07 ` Johannes Berg
2016-03-03 15:12 ` Felix Fietkau
2016-03-03 14:54 ` [PATCH v2 1/2] mac80211: add A-MSDU tx support Johannes Berg
2016-03-03 15:11 ` Felix Fietkau
2016-03-03 15:37 ` Johannes Berg [this message]
2016-03-03 15:55 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457019447.2044.24.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).