From: Johannes Berg <johannes@sipsolutions.net>
To: Dima Krasner <dima@dimakrasner.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: add libnl-tiny support
Date: Tue, 08 Mar 2016 18:00:20 +0100 [thread overview]
Message-ID: <1457456420.24270.16.camel@sipsolutions.net> (raw)
In-Reply-To: <20160305175115.4476ee00292f15f60aad4497@dimakrasner.com>
This:
> -#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30)
> +#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) && !defined(CONFIG_LIBNL_TINY)
> -#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 */
> +#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 && CONFIG_LIBNL_TINY */
can be handled by just defining CONFIG_LIBNL20 for libnl-tiny.
> -/* libnl 1.x compatibility code */
> +/* libnl 1.x and libnl-tiny compatibility code */
> #if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30)
> # define nl_sock nl_handle
> #endif
Are you sure this is needed? Elsewhere you said libnl-tiny uses libnl20
compatible API, which is with nl_handle. If this is needed perhaps some
code erroneously uses nl_sock instead of nl_handle?
Perhaps we should also consider treating 2.0/3.x as the default API and
use nl_handle instead of nl_sock in the code.
johannes
next prev parent reply other threads:[~2016-03-08 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 18:43 [PATCH] iw: add libnl-tiny support Dima Krasner
2016-03-02 13:59 ` Johannes Berg
2016-03-05 15:51 ` Dima Krasner
2016-03-08 17:00 ` Johannes Berg [this message]
2016-03-05 15:11 ` [PATCH] iw: add libnl-tiny support, reimplemented Dima Krasner
2016-03-06 12:39 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2015-11-03 22:14 [PATCH] iw: Add libnl-tiny support Dima Krasner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457456420.24270.16.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dima@dimakrasner.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).