linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: johannes@sipsolutions.net, davem@davemloft.net,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix order of flag descriptions
Date: Fri, 18 Mar 2016 10:46:03 -0700	[thread overview]
Message-ID: <1458323163.26915.8.camel@perches.com> (raw)
In-Reply-To: <56EC3DA6.2090105@osg.samsung.com>

On Fri, 2016-03-18 at 17:40 +0000, Luis de Bethencourt wrote:
> On 18/03/16 17:29, Joe Perches wrote:
> > On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
> > > Fix order of mac80211_rx_flags description to match the enum.
[]
> > > I want ahead and fixed the order of the descriptions. checkpatch.pl was giving
> > > a warning to my previous patch and I had a hunch it was because the wrong order
> > > breaks the parser. Indeed it does and with this patch below checkpatch.pl does
> > > not complain about this flag descriptions anymore.
> > checkpatch complains?  About what?
> warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags'

That's not a checkpatch warning.

cheers, Joe

  reply	other threads:[~2016-03-18 17:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 16:09 [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt
2016-03-18 16:35 ` [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt
2016-03-18 16:49   ` Johannes Berg
2016-03-18 17:46     ` Luis de Bethencourt
2016-03-18 18:20       ` Luis de Bethencourt
2016-03-18 17:29   ` Joe Perches
2016-03-18 17:40     ` Luis de Bethencourt
2016-03-18 17:46       ` Joe Perches [this message]
2016-03-18 17:49         ` Luis de Bethencourt
2016-03-18 18:54 ` [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt
2016-04-05  9:11 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458323163.26915.8.camel@perches.com \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).