From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, Avraham Stern <avraham.stern@intel.com>
Subject: Re: [PATCH 2/5] mac80211: add an option to not disconnect on beacon loss
Date: Sat, 19 Mar 2016 10:57:02 +0100 [thread overview]
Message-ID: <1458381422.12902.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1458222099-30301-2-git-send-email-emmanuel.grumbach@intel.com>
On Thu, 2016-03-17 at 15:41 +0200, Emmanuel Grumbach wrote:
> ifmgd->probe_send_count = 0;
> + sdata->u.mgd.flags &= ~IEEE80211_STA_BEACON_LOSS_REPORTED;
This is very racy, concurrent RX will corrupt the flags value since
this requires a read-modify-write and cannot be done with locking.
I can't apply this.
johannes
next prev parent reply other threads:[~2016-03-19 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 13:41 [PATCH 1/5] nl80211: add an option to set driver action for beacon loss Emmanuel Grumbach
2016-03-17 13:41 ` [PATCH 2/5] mac80211: add an option to not disconnect on " Emmanuel Grumbach
2016-03-19 9:57 ` Johannes Berg [this message]
2016-03-17 13:41 ` [PATCH 3/5] mac80211: avoid useless memory write on each frame RX Emmanuel Grumbach
2016-03-17 13:41 ` [PATCH 4/5] cfg80211: allow userspace to specify client P2P PS support Emmanuel Grumbach
2016-03-17 13:41 ` [PATCH 5/5] mac80211: track and tell driver about GO client P2P PS abilities Emmanuel Grumbach
2016-04-05 10:18 ` [PATCH 1/5] nl80211: add an option to set driver action for beacon loss Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458381422.12902.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avraham.stern@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).