linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats
@ 2016-03-28 11:33 Colin King
  2016-03-28 11:39 ` Grumbach, Emmanuel
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-03-28 11:33 UTC (permalink / raw)
  To: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless,
	Kalle Valo, Sara Sharon, linux-wireless, netdev
  Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

isr_stats is written twice with the same value, remove one of the
redundant assignments to isr_stats.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
index 4be3c35..253e4f0 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
@@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id)
 	struct msix_entry *entry = dev_id;
 	struct iwl_trans_pcie *trans_pcie = iwl_pcie_get_trans_pcie(entry);
 	struct iwl_trans *trans = trans_pcie->trans;
-	struct isr_statistics *isr_stats = isr_stats = &trans_pcie->isr_stats;
+	struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
 	u32 inta_fh, inta_hw;
 
 	lock_map_acquire(&trans->sync_cmd_lockdep_map);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats
  2016-03-28 11:33 [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Colin King
@ 2016-03-28 11:39 ` Grumbach, Emmanuel
  0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-28 11:39 UTC (permalink / raw)
  To: linuxwifi, colin.king@canonical.com, kvalo@codeaurora.org,
	Sharon, Sara, netdev@vger.kernel.org, Berg, Johannes,
	linux-wireless@vger.kernel.org
  Cc: linux-kernel@vger.kernel.org

T24gTW9uLCAyMDE2LTAzLTI4IGF0IDEyOjMzICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG
cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gaXNy
X3N0YXRzIGlzIHdyaXR0ZW4gdHdpY2Ugd2l0aCB0aGUgc2FtZSB2YWx1ZSwgcmVtb3ZlIG9uZSBv
ZiB0aGUNCj4gcmVkdW5kYW50IGFzc2lnbm1lbnRzIHRvIGlzcl9zdGF0cy4NCj4gDQo+IFNpZ25l
ZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+DQo+IC0t
LQ0KDQoNCkFwcGxpZWQgLSB0aGFua3MuDQoNCj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVs
L2l3bHdpZmkvcGNpZS9yeC5jIHwgMiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u
KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxl
c3MvaW50ZWwvaXdsd2lmaS9wY2llL3J4LmMNCj4gYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRl
bC9pd2x3aWZpL3BjaWUvcnguYw0KPiBpbmRleCA0YmUzYzM1Li4yNTNlNGYwIDEwMDY0NA0KPiAt
LS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRlbC9pd2x3aWZpL3BjaWUvcnguYw0KPiArKysg
Yi9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRlbC9pd2x3aWZpL3BjaWUvcnguYw0KPiBAQCAtMTgw
NSw3ICsxODA1LDcgQEAgaXJxcmV0dXJuX3QgaXdsX3BjaWVfaXJxX21zaXhfaGFuZGxlcihpbnQg
aXJxLA0KPiB2b2lkICpkZXZfaWQpDQo+ICAJc3RydWN0IG1zaXhfZW50cnkgKmVudHJ5ID0gZGV2
X2lkOw0KPiAgCXN0cnVjdCBpd2xfdHJhbnNfcGNpZSAqdHJhbnNfcGNpZSA9DQo+IGl3bF9wY2ll
X2dldF90cmFuc19wY2llKGVudHJ5KTsNCj4gIAlzdHJ1Y3QgaXdsX3RyYW5zICp0cmFucyA9IHRy
YW5zX3BjaWUtPnRyYW5zOw0KPiAtCXN0cnVjdCBpc3Jfc3RhdGlzdGljcyAqaXNyX3N0YXRzID0g
aXNyX3N0YXRzID0gJnRyYW5zX3BjaWUNCj4gLT5pc3Jfc3RhdHM7DQo+ICsJc3RydWN0IGlzcl9z
dGF0aXN0aWNzICppc3Jfc3RhdHMgPSAmdHJhbnNfcGNpZS0+aXNyX3N0YXRzOw0KPiAgCXUzMiBp
bnRhX2ZoLCBpbnRhX2h3Ow0KPiAgDQo+ICAJbG9ja19tYXBfYWNxdWlyZSgmdHJhbnMtPnN5bmNf
Y21kX2xvY2tkZXBfbWFwKTs=

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-28 11:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 11:33 [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Colin King
2016-03-28 11:39 ` Grumbach, Emmanuel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).