From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:45676 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbcCaPWv (ORCPT ); Thu, 31 Mar 2016 11:22:51 -0400 Message-ID: <1459437761.4576.25.camel@sipsolutions.net> (sfid-20160331_172312_664310_62FA2E0B) Subject: Re: Question on rhashtable in worst-case scenario. From: Johannes Berg To: Ben Greear , David Miller Cc: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, tgraf@suug.ch Date: Thu, 31 Mar 2016 17:22:41 +0200 In-Reply-To: <56FD3E91.9020804@candelatech.com> References: <56F9941A.3080501@candelatech.com> <56FAAA6D.3070806@candelatech.com> <1459329252.2055.1.camel@sipsolutions.net> <20160330.123821.328761526754742195.davem@davemloft.net> <56FC0445.6010200@candelatech.com> <1459410405.4576.8.camel@sipsolutions.net> <56FD3E91.9020804@candelatech.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2016-03-31 at 08:13 -0700, Ben Greear wrote: >  > I see insertion failure, and then later, if of course fails to delete > as well since it was never inserted to begin with.  There is no good > way to deal with insertion error, so just need to fix the hashtable. Oh, that's an oversight in mac80211 - it should be dealing with insertion failures properly. This isn't really a problem either, although it will lead to errors in your particular case. https://p.sipsolutions.net/cf77c78d69a231d4.txt johannes