From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:58684 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbcDBSdz (ORCPT ); Sat, 2 Apr 2016 14:33:55 -0400 Message-ID: <1459622014.18188.2.camel@sipsolutions.net> (sfid-20160402_203426_683828_07113488) Subject: Re: Question on rhashtable in worst-case scenario. From: Johannes Berg To: Herbert Xu Cc: Ben Greear , David Miller , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, tgraf@suug.ch Date: Sat, 02 Apr 2016 20:33:34 +0200 In-Reply-To: <20160402014653.GA19235@gondor.apana.org.au> References: <56F9941A.3080501@candelatech.com> <56FAAA6D.3070806@candelatech.com> <1459329252.2055.1.camel@sipsolutions.net> <20160330.123821.328761526754742195.davem@davemloft.net> <56FC0445.6010200@candelatech.com> <1459410405.4576.8.camel@sipsolutions.net> <20160331075015.GA27716@gondor.apana.org.au> <1459438199.4576.26.camel@sipsolutions.net> <20160401004627.GA9367@gondor.apana.org.au> <1459546450.3342.22.camel@sipsolutions.net> <20160402014653.GA19235@gondor.apana.org.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 2016-04-02 at 09:46 +0800, Herbert Xu wrote: > On Fri, Apr 01, 2016 at 11:34:10PM +0200, Johannes Berg wrote: > > > > > > I was thinking about that one - it's not obvious to me from the > > code > > how this "explicitly checking for dups" would be done or let's say > > how > > rhashtable differentiates. But since it seems to work for Ben until > > hitting a certain number of identical keys, surely that's just me > > not > > understanding the code rather than anything else :) > It's really simple, rhashtable_insert_fast does not check for dups > while rhashtable_lookup_insert_* do. Oh, ok, thanks :) johannes