From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: close the SP when we enqueue frames during the SP
Date: Tue, 05 Apr 2016 11:34:13 +0200 [thread overview]
Message-ID: <1459848853.18188.26.camel@sipsolutions.net> (raw)
In-Reply-To: <1458226302-6086-2-git-send-email-emmanuel.grumbach@intel.com>
On Thu, 2016-03-17 at 16:51 +0200, Emmanuel Grumbach wrote:
> Since we enqueued the frame that was supposed to be sent
> during the SP, and that frame may very well cary the
> IEEE80211_TX_STATUS_EOSP bit, we may never close the SP
> (WLAN_STA_SP will never be cleared). If that happens, we
> will not open any new SP and will never respond to any poll
> frame from the client.
> Clear WLAN_STA_SP manually if a frame that was polled during
> the SP is queued because of a starting A-MPDU session. The
> client may not see the EOSP bit, but it will at least be
> able to poll new frames in another SP.
>
Also applied.
johannes
next prev parent reply other threads:[~2016-04-05 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 14:51 [PATCH 1/2] mac80211: don't send deferred frames outside the SP Emmanuel Grumbach
2016-03-17 14:51 ` [PATCH 2/2] mac80211: close the SP when we enqueue frames during " Emmanuel Grumbach
2016-04-05 9:34 ` [PATCH v2] " Emmanuel Grumbach
2016-04-05 9:34 ` Johannes Berg [this message]
2016-04-05 9:17 ` [PATCH 1/2] mac80211: don't send deferred frames outside " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459848853.18188.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).